third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 1442463002: Save-Page-As-Complete-HTML: Even better handling of <object> elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 1442463002: Save-Page-As-Complete-HTML: Even better handling of <object> elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@objects-fix-for-complete-html

Patch Set: s/\<u\>/element_url/g in savable_resources.cc Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index 7428894fcc501ea218c3a879b21f3205e2023bef..932bf11b21faaf11e7298c2918cee8f92adb9db0 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -1823,10 +1823,9 @@ WebLocalFrameImpl* WebLocalFrameImpl::fromFrame(LocalFrame& frame)

WebLocalFrameImpl* WebLocalFrameImpl::fromFrameOwnerElement(Element* element)

{

- // FIXME: Why do we check specifically for <iframe> and <frame> here? Why can't we get the WebLocalFrameImpl from an <object> element, for example.

- if (!isHTMLFrameElementBase(element))

+ if (!element->isFrameOwnerElement())

return 0;

yosin_UTC9 2015/11/24 01:32:41 I think it is OK to replace |0| to |nullptr| in th

Łukasz Anforowicz 2015/11/24 17:57:11 Done. (here and in a few surrounding / related fu

- return fromFrame(toLocalFrame(toHTMLFrameElementBase(element)->contentFrame()));

+ return fromFrame(toLocalFrame(toHTMLFrameOwnerElement(element)->contentFrame()));

}

WebViewImpl* WebLocalFrameImpl::viewImpl() const

« content/renderer/savable_resources.cc ('K') | « third_party/WebKit/Source/web/WebFrame.cpp ('k') | no next file » | no next file with comments »