third_party/WebKit/Source/web/WebFrame.cpp - Issue 1442463002: Save-Page-As-Complete-HTML: Even better handling of <object> elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebFrame.cpp

Issue 1442463002: Save-Page-As-Complete-HTML: Even better handling of <object> elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@objects-fix-for-complete-html

Patch Set: s/\<u\>/element_url/g in savable_resources.cc Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/savable_resources.cc ('K') | « content/renderer/savable_resources.cc ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('j') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebFrame.cpp

diff --git a/third_party/WebKit/Source/web/WebFrame.cpp b/third_party/WebKit/Source/web/WebFrame.cpp

index 5479891ff3c8cfbf84a641131ada03b3a44981ef..f050e9961872f0663345b20b47185a94cdc49d31 100644

--- a/third_party/WebKit/Source/web/WebFrame.cpp

+++ b/third_party/WebKit/Source/web/WebFrame.cpp

@@ -277,9 +277,9 @@ WebFrame* WebFrame::fromFrameOwnerElement(const WebElement& webElement)

{

Element* element = PassRefPtrWillBeRawPtr<Element>(webElement).get();

- if (!isHTMLFrameElementBase(element))

+ if (!element->isFrameOwnerElement())

return nullptr;

- return fromFrame(toHTMLFrameElementBase(element)->contentFrame());

+ return fromFrame(toHTMLFrameOwnerElement(element)->contentFrame());

}

bool WebFrame::isLoading() const