Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: chrome/renderer/net/net_error_helper.h

Issue 1442433003: Add "Show saved copy" button in dino page when there's offline copy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add more comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/net/net_error_helper.h
diff --git a/chrome/renderer/net/net_error_helper.h b/chrome/renderer/net/net_error_helper.h
index 935cd5df1f241e8ede567f23b3483f0d8d3a6fac..5f4169b5bb1422bc21616fadc506a61d76998dfa 100644
--- a/chrome/renderer/net/net_error_helper.h
+++ b/chrome/renderer/net/net_error_helper.h
@@ -83,19 +83,20 @@ class NetErrorHelper
const blink::WebURLError& error,
bool is_failed_post,
bool can_use_local_diagnostics_service,
- bool has_offline_pages,
+ int offline_page_status,
scoped_ptr<error_page::ErrorPageParams> params,
bool* reload_button_shown,
bool* show_saved_copy_button_shown,
bool* show_cached_copy_button_shown,
- bool* show_saved_pages_button_shown,
+ bool* show_offline_pages_button_shown,
+ bool* show_offline_copy_button_shown,
std::string* html) const override;
void LoadErrorPage(const std::string& html, const GURL& failed_url) override;
void EnablePageHelperFunctions() override;
void UpdateErrorPage(const blink::WebURLError& error,
bool is_failed_post,
bool can_use_local_diagnostics_service,
- bool has_offline_pages) override;
+ int offline_page_status) override;
void FetchNavigationCorrections(
const GURL& navigation_correction_url,
const std::string& navigation_correction_request_body) override;
@@ -106,6 +107,7 @@ class NetErrorHelper
void LoadPageFromCache(const GURL& page_url) override;
void DiagnoseError(const GURL& page_url) override;
void ShowOfflinePages() override;
+ void LoadOfflineCopy(const GURL& page_url) override;
void OnNetErrorInfo(int status);
void OnSetCanShowNetworkDiagnosticsDialog(
@@ -121,8 +123,11 @@ class NetErrorHelper
void OnTrackingRequestComplete(const blink::WebURLResponse& response,
const std::string& data);
+
+ // Called to set the status of the offline pages that will be used to decide
+ // if offline related button will be provided in the error page.
nasko 2015/11/13 23:55:13 Comment should be included in the #if defined sect
jianli 2015/11/14 00:26:05 Done.
#if defined(OS_ANDROID)
- void OnSetHasOfflinePages(bool has_offline_pages);
+ void OnSetOfflinePageInfo(int offline_page_status);
#endif
scoped_ptr<content::ResourceFetcher> correction_fetcher_;

Powered by Google App Engine
This is Rietveld 408576698