Add "Show saved copy" button in dino page when there's offline copy

chrome/common/render_messages.h

Index: chrome/common/render_messages.h
diff --git a/chrome/common/render_messages.h b/chrome/common/render_messages.h
index e096a931ac55f5f02da1eea0fb22de14d0c6336d..d63de501e3c7e571b3bb5296f5224fdd3e0385bd 100644
--- a/chrome/common/render_messages.h
+++ b/chrome/common/render_messages.h
@@ -323,11 +323,11 @@ IPC_MESSAGE_ROUTED1(ChromeViewMsg_SetCanShowNetworkDiagnosticsDialog,
                     bool /* can_show_network_diagnostics_dialog */)
 
 #if defined(OS_ANDROID)
-// Tells the renderer whether or not an offline page exists. This is used to
-// decide if "show saved pages" button will be provided on certain error page.
-IPC_MESSAGE_ROUTED1(ChromeViewMsg_SetHasOfflinePages,
-                    bool /* has_offline_pages */)
-#endif
+// Tells the renderer about the status of the offline pages. This is used to
+// decide if offline related button will be provided on certain error page.
+IPC_MESSAGE_ROUTED1(ChromeViewMsg_SetOfflinePageInfo,
+                    int /* offline_page_status */)

[nasko, 2015/11/13 23:55:13]

Since there is OfflinePageStatus enum, why not use it here?

[jianli, 2015/11/14 00:26:05]

We will then have to add IPC::ParamTraits instantiation for this enum. Also I
need to include localized_error.h in several places which might not be what we
want.

[nasko, 2015/11/14 00:43:49]

You don't need to add IPC::ParamTraits, you just need to define its range using
a macro - IPC_ENUM_TRAITS_MIN_MAX_VALUE(type, minvalue, maxvalue);

It can be put in a common header file that makes sense to be included in all the
locations this is needed.

[jianli, 2015/11/17 00:06:49]

Done.

+#endif  // defined(OS_ANDROID)
 
 // Provides the information needed by the renderer process to contact a
 // navigation correction service.  Handled by the NetErrorHelper.
@@ -345,7 +345,12 @@ IPC_MESSAGE_ROUTED1(ChromeViewHostMsg_RunNetworkDiagnostics,
 // Message sent from the renderer to the browser to show the UI for offline
 // pages.
 IPC_MESSAGE_ROUTED0(ChromeViewHostMsg_ShowOfflinePages)
-#endif
+
+// Message sent from the renderer to the browser to load the offline copy of
+// the page that fails to load due to no internet.

[nasko, 2015/11/13 23:55:13]

s/internet/network connectivity/

[jianli, 2015/11/14 00:26:05]

Done.

+IPC_MESSAGE_ROUTED1(ChromeViewHostMsg_LoadOfflineCopy,
+                    GURL /* url */)
+#endif  // defined(OS_ANDROID)
 
 //-----------------------------------------------------------------------------
 // Misc messages