Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: chrome/common/render_messages.h

Issue 1442433003: Add "Show saved copy" button in dino page when there's offline copy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add more comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Multiply-included file, no traditional include guard. 5 // Multiply-included file, no traditional include guard.
6 #include <stdint.h> 6 #include <stdint.h>
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 // page with more specific troubleshooting suggestions. 316 // page with more specific troubleshooting suggestions.
317 IPC_MESSAGE_ROUTED1(ChromeViewMsg_NetErrorInfo, 317 IPC_MESSAGE_ROUTED1(ChromeViewMsg_NetErrorInfo,
318 int /* DNS probe status */) 318 int /* DNS probe status */)
319 319
320 // Tells the renderer whether or not there is a local diagnostics service that 320 // Tells the renderer whether or not there is a local diagnostics service that
321 // can be run via ChromeViewHostMsg_RunNetworkDiagnostics messages. 321 // can be run via ChromeViewHostMsg_RunNetworkDiagnostics messages.
322 IPC_MESSAGE_ROUTED1(ChromeViewMsg_SetCanShowNetworkDiagnosticsDialog, 322 IPC_MESSAGE_ROUTED1(ChromeViewMsg_SetCanShowNetworkDiagnosticsDialog,
323 bool /* can_show_network_diagnostics_dialog */) 323 bool /* can_show_network_diagnostics_dialog */)
324 324
325 #if defined(OS_ANDROID) 325 #if defined(OS_ANDROID)
326 // Tells the renderer whether or not an offline page exists. This is used to 326 // Tells the renderer about the status of the offline pages. This is used to
327 // decide if "show saved pages" button will be provided on certain error page. 327 // decide if offline related button will be provided on certain error page.
328 IPC_MESSAGE_ROUTED1(ChromeViewMsg_SetHasOfflinePages, 328 IPC_MESSAGE_ROUTED1(ChromeViewMsg_SetOfflinePageInfo,
329 bool /* has_offline_pages */) 329 int /* offline_page_status */)
nasko 2015/11/13 23:55:13 Since there is OfflinePageStatus enum, why not use
jianli 2015/11/14 00:26:05 We will then have to add IPC::ParamTraits instanti
nasko 2015/11/14 00:43:49 You don't need to add IPC::ParamTraits, you just n
jianli 2015/11/17 00:06:49 Done.
330 #endif 330 #endif // defined(OS_ANDROID)
331 331
332 // Provides the information needed by the renderer process to contact a 332 // Provides the information needed by the renderer process to contact a
333 // navigation correction service. Handled by the NetErrorHelper. 333 // navigation correction service. Handled by the NetErrorHelper.
334 IPC_MESSAGE_ROUTED5(ChromeViewMsg_SetNavigationCorrectionInfo, 334 IPC_MESSAGE_ROUTED5(ChromeViewMsg_SetNavigationCorrectionInfo,
335 GURL /* Navigation correction service base URL */, 335 GURL /* Navigation correction service base URL */,
336 std::string /* language */, 336 std::string /* language */,
337 std::string /* origin_country */, 337 std::string /* origin_country */,
338 std::string /* API key to use */, 338 std::string /* API key to use */,
339 GURL /* Google Search URL to use */) 339 GURL /* Google Search URL to use */)
340 340
341 IPC_MESSAGE_ROUTED1(ChromeViewHostMsg_RunNetworkDiagnostics, 341 IPC_MESSAGE_ROUTED1(ChromeViewHostMsg_RunNetworkDiagnostics,
342 GURL /* failed_url */) 342 GURL /* failed_url */)
343 343
344 #if defined(OS_ANDROID) 344 #if defined(OS_ANDROID)
345 // Message sent from the renderer to the browser to show the UI for offline 345 // Message sent from the renderer to the browser to show the UI for offline
346 // pages. 346 // pages.
347 IPC_MESSAGE_ROUTED0(ChromeViewHostMsg_ShowOfflinePages) 347 IPC_MESSAGE_ROUTED0(ChromeViewHostMsg_ShowOfflinePages)
348 #endif 348
349 // Message sent from the renderer to the browser to load the offline copy of
350 // the page that fails to load due to no internet.
nasko 2015/11/13 23:55:13 s/internet/network connectivity/
jianli 2015/11/14 00:26:05 Done.
351 IPC_MESSAGE_ROUTED1(ChromeViewHostMsg_LoadOfflineCopy,
352 GURL /* url */)
353 #endif // defined(OS_ANDROID)
349 354
350 //----------------------------------------------------------------------------- 355 //-----------------------------------------------------------------------------
351 // Misc messages 356 // Misc messages
352 // These are messages sent from the renderer to the browser process. 357 // These are messages sent from the renderer to the browser process.
353 358
354 IPC_MESSAGE_CONTROL1(ChromeViewHostMsg_UpdatedCacheStats, 359 IPC_MESSAGE_CONTROL1(ChromeViewHostMsg_UpdatedCacheStats,
355 blink::WebCache::UsageStats /* stats */) 360 blink::WebCache::UsageStats /* stats */)
356 361
357 // Sent by the renderer process to check whether access to FileSystem is 362 // Sent by the renderer process to check whether access to FileSystem is
358 // granted by content settings. 363 // granted by content settings.
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
579 584
580 // Record a sample string to a Rappor metric. 585 // Record a sample string to a Rappor metric.
581 IPC_MESSAGE_CONTROL2(ChromeViewHostMsg_RecordRappor, 586 IPC_MESSAGE_CONTROL2(ChromeViewHostMsg_RecordRappor,
582 std::string /* metric */, 587 std::string /* metric */,
583 std::string /* sample */) 588 std::string /* sample */)
584 589
585 // Record a domain and registry of a url to a Rappor metric. 590 // Record a domain and registry of a url to a Rappor metric.
586 IPC_MESSAGE_CONTROL2(ChromeViewHostMsg_RecordRapporURL, 591 IPC_MESSAGE_CONTROL2(ChromeViewHostMsg_RecordRapporURL,
587 std::string /* metric */, 592 std::string /* metric */,
588 GURL /* sample url */) 593 GURL /* sample url */)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698