Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: Source/modules/webmidi/MIDIErrorCallback.h

Issue 14423002: Web MIDI: implement MIDIErrorCallback (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: (rebase) Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webmidi/MIDIErrorCallback.h
diff --git a/Source/core/dom/StringCallback.h b/Source/modules/webmidi/MIDIErrorCallback.h
similarity index 79%
copy from Source/core/dom/StringCallback.h
copy to Source/modules/webmidi/MIDIErrorCallback.h
index 92e83e2196093b00a42ae9fde89b2612821d2d45..1cfc148c9b2d3466376711401bca47fcac9352e7 100644
--- a/Source/core/dom/StringCallback.h
+++ b/Source/modules/webmidi/MIDIErrorCallback.h
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2010 Google Inc. All rights reserved.
+ * Copyright (C) 2013 Google Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
@@ -28,25 +28,26 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef StringCallback_h
-#define StringCallback_h
+#ifndef MIDIErrorCallback_h
+#define MIDIErrorCallback_h
-#include <wtf/Forward.h>
+#include <wtf/PassRefPtr.h>
tkent 2013/04/24 02:08:43 Please quote by "", instead of <>.
Takashi Toyoshima 2013/04/24 02:23:12 Done.
#include <wtf/RefCounted.h>
namespace WebCore {
+class DOMError;
class ScriptExecutionContext;
-class StringCallback : public RefCounted<StringCallback> {
+class MIDIErrorCallback : public RefCounted<MIDIErrorCallback> {
public:
- virtual ~StringCallback() { }
- virtual bool handleEvent(const String& data) = 0;
+ virtual ~MIDIErrorCallback() { }
+ virtual bool handleEvent(DOMError*) = 0;
// Helper to post callback task.
- void scheduleCallback(ScriptExecutionContext*, const String& data);
+ void scheduleCallback(ScriptExecutionContext*, PassRefPtr<DOMError>);
};
-} // namespace WebCore
+} // namespace
tkent 2013/04/24 02:08:43 Just "namespace" is confusing. It should be "name
Takashi Toyoshima 2013/04/24 02:23:12 Done.
-#endif // StringCallback_h
+#endif // MIDIErrorCallback_h

Powered by Google App Engine
This is Rietveld 408576698