Web MIDI: implement MIDIErrorCallback

Source/modules/webmidi/MIDIErrorCallback.h

 /*
- * Copyright (C) 2010 Google Inc. All rights reserved.
+ * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
  * copyright notice, this list of conditions and the following disclaimer
  * in the documentation and/or other materials provided with the
  * distribution.
  *     * Neither the name of Google Inc. nor the names of its
  * contributors may be used to endorse or promote products derived from
  * this software without specific prior written permission.
  *
  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
  * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
  * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef StringCallback_h
-#define StringCallback_h
+#ifndef MIDIErrorCallback_h
+#define MIDIErrorCallback_h
 
-#include <wtf/Forward.h>
+#include <wtf/PassRefPtr.h>

[tkent, 2013/04/24 02:08:43]

Please quote by "", instead of <>.

[Takashi Toyoshima, 2013/04/24 02:23:12]

Done.

 #include <wtf/RefCounted.h>
 
 namespace WebCore {
 
+class DOMError;
 class ScriptExecutionContext;
 
-class StringCallback : public RefCounted<StringCallback> {
+class MIDIErrorCallback : public RefCounted<MIDIErrorCallback> {
 public:
-    virtual ~StringCallback() { }
-    virtual bool handleEvent(const String& data) = 0;
+    virtual ~MIDIErrorCallback() { }
+    virtual bool handleEvent(DOMError*) = 0;
 
     // Helper to post callback task.
-    void scheduleCallback(ScriptExecutionContext*, const String& data);
+    void scheduleCallback(ScriptExecutionContext*, PassRefPtr<DOMError>);
 };
 
-} // namespace WebCore
+} // namespace

[tkent, 2013/04/24 02:08:43]

Just "namespace" is confusing.  It should be "namespace WebCore", or we should
remove the comment.

[Takashi Toyoshima, 2013/04/24 02:23:12]

Done.

 
-#endif // StringCallback_h
+#endif // MIDIErrorCallback_h