Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1442153002: Oilpan: correctly track MediaControlsTest's MediaControls reference. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, nessy, mlamouri+watch-blink_chromium.org, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews, vcarbune.chromium, philipj_slow
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: correctly track MediaControlsTest's MediaControls reference. R=haraken BUG=553613 Committed: https://crrev.com/5bbe62bfa0f3c57871f5a1c1cabface9ff19a768 Cr-Commit-Position: refs/heads/master@{#359753}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp View 2 chunks +2 lines, -1 line 1 comment Download

Messages

Total messages: 10 (5 generated)
sof
5 years, 1 month ago (2015-11-14 06:31:14 UTC) #3
haraken
LGTM https://codereview.chromium.org/1442153002/diff/1/third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp File third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp (right): https://codereview.chromium.org/1442153002/diff/1/third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp#newcode70 third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp:70: RawPtrWillBePersistent<MediaControls> m_mediaControls; Nit: This could be RefPtrWillBePersistent.
5 years, 1 month ago (2015-11-14 07:08:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442153002/1
5 years, 1 month ago (2015-11-14 07:10:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-15 02:41:27 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-15 02:42:40 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5bbe62bfa0f3c57871f5a1c1cabface9ff19a768
Cr-Commit-Position: refs/heads/master@{#359753}

Powered by Google App Engine
This is Rietveld 408576698