third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp - Issue 1442153002: Oilpan: correctly track MediaControlsTest's MediaControls reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp

Issue 1442153002: Oilpan: correctly track MediaControlsTest's MediaControls reference. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp

index 31a29ae0c5c6582c085350615c01d1cee3193ccf..61ef850d5bb0fa198de4df01ac279eb8650befee 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp

@@ -11,6 +11,7 @@

#include "core/dom/ElementTraversal.h"

#include "core/html/HTMLVideoElement.h"

#include "core/testing/DummyPageHolder.h"

+#include "platform/heap/Handle.h"

#include <gtest/gtest.h>

namespace blink {

@@ -66,7 +67,7 @@ protected:

private:

OwnPtr<DummyPageHolder> m_pageHolder;

- MediaControls* m_mediaControls;

+ RawPtrWillBePersistent<MediaControls> m_mediaControls;

haraken 2015/11/14 07:08:23 Nit: This could be RefPtrWillBePersistent.

};

TEST_F(MediaControlsTest, HideAndShow)

« no previous file with comments | « no previous file | no next file » | no next file with comments »