Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1442143003: Fix gcc 4.9.2 signed-compare error. (Closed)

Created:
5 years, 1 month ago by paul.l...
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix gcc 4.9.2 signed-compare error. From 60e7ea8a99 / https://codereview.chromium.org/1409993012 BUG= Committed: https://crrev.com/2058991122796f13b31ac3480c23e1dcb44f3991 Cr-Commit-Position: refs/heads/master@{#31999}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M test/unittests/cancelable-tasks-unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
paul.l...
PTAL. Another of these annoying warnings. I'll have a look at turning off signed-compare warnings ...
5 years, 1 month ago (2015-11-14 02:01:43 UTC) #3
Michael Lippautz
lgtm, thanks for fixing!
5 years, 1 month ago (2015-11-14 02:52:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442143003/1
5 years, 1 month ago (2015-11-14 03:04:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/11846)
5 years, 1 month ago (2015-11-14 09:12:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442143003/1
5 years, 1 month ago (2015-11-15 12:29:33 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-15 12:48:15 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-15 12:48:30 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2058991122796f13b31ac3480c23e1dcb44f3991
Cr-Commit-Position: refs/heads/master@{#31999}

Powered by Google App Engine
This is Rietveld 408576698