Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1087)

Unified Diff: test/unittests/cancelable-tasks-unittest.cc

Issue 1442143003: Fix gcc 4.9.2 signed-compare error. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/cancelable-tasks-unittest.cc
diff --git a/test/unittests/cancelable-tasks-unittest.cc b/test/unittests/cancelable-tasks-unittest.cc
index 70d9b1f28237ea01863f7201e7fa2fb782164b5d..37690aaf80678f39e799579b285f184296e71d5e 100644
--- a/test/unittests/cancelable-tasks-unittest.cc
+++ b/test/unittests/cancelable-tasks-unittest.cc
@@ -116,8 +116,8 @@ TEST(CancelableTask, SequentialMultipleTasks) {
TestTask* task2 = new TestTask(&manager, &result2);
SequentialRunner runner1(task1);
SequentialRunner runner2(task2);
- EXPECT_EQ(task1->id(), 1);
- EXPECT_EQ(task2->id(), 2);
+ EXPECT_EQ(task1->id(), 1u);
+ EXPECT_EQ(task2->id(), 2u);
EXPECT_EQ(GetValue(&result1), 0);
runner1.Run(); // Don't touch task1 after running it.
@@ -181,7 +181,7 @@ TEST(CancelableTask, RemoveBeforeCancelAndWait) {
TestTask* task1 = new TestTask(&manager, &result1, TestTask::kCheckNotRun);
ThreadedRunner runner1(task1);
uint32_t id = task1->id();
- EXPECT_EQ(id, 1);
+ EXPECT_EQ(id, 1u);
EXPECT_TRUE(manager.TryAbort(id));
runner1.Start();
runner1.Join();
@@ -196,7 +196,7 @@ TEST(CancelableTask, RemoveAfterCancelAndWait) {
TestTask* task1 = new TestTask(&manager, &result1);
ThreadedRunner runner1(task1);
uint32_t id = task1->id();
- EXPECT_EQ(id, 1);
+ EXPECT_EQ(id, 1u);
runner1.Start();
runner1.Join();
manager.CancelAndWait();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698