Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3393)

Unified Diff: chrome/browser/notifications/notification_permission_context_unittest.cc

Issue 1442083002: Stop inheriting push notification permissions from regular to incognito (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_permission_context_unittest.cc
diff --git a/chrome/browser/notifications/notification_permission_context_unittest.cc b/chrome/browser/notifications/notification_permission_context_unittest.cc
index 778b6f109fe873d4bf4de277e18517c808756502..c42d6b13fa6c1951a53766dde549470fded9a0b9 100644
--- a/chrome/browser/notifications/notification_permission_context_unittest.cc
+++ b/chrome/browser/notifications/notification_permission_context_unittest.cc
@@ -60,3 +60,25 @@ TEST(NotificationPermissionContextTest, NoSecureOriginRequirement) {
EXPECT_EQ(CONTENT_SETTING_ALLOW,
context.GetPermissionStatus(origin, origin));
}
+
+TEST(NotificationPermissionContextTest, NotInheritedInIncognito) {
+ content::TestBrowserThreadBundle thread_bundle;
+ TestingProfile regular_profile;
+ Profile* incognito_profile = regular_profile.GetOffTheRecordProfile();
+
+ GURL origin("http://example.com");
+
+ NotificationPermissionContext regular_context(&regular_profile);
+ NotificationPermissionContext incognito_context(incognito_profile);
+ EXPECT_EQ(CONTENT_SETTING_ASK,
+ regular_context.GetPermissionStatus(origin, origin));
+ EXPECT_EQ(CONTENT_SETTING_ASK,
+ incognito_context.GetPermissionStatus(origin, origin));
+
+ regular_context.UpdateContentSetting(origin, origin, CONTENT_SETTING_ALLOW);
+
+ EXPECT_EQ(CONTENT_SETTING_ALLOW,
+ regular_context.GetPermissionStatus(origin, origin));
+ EXPECT_EQ(CONTENT_SETTING_ASK,
+ incognito_context.GetPermissionStatus(origin, origin));
+}

Powered by Google App Engine
This is Rietveld 408576698