chrome/browser/notifications/notification_permission_context.h - Issue 1442083002: Stop inheriting push notification permissions from regular to incognito

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_permission_context.h

Issue 1442083002: Stop inheriting push notification permissions from regular to incognito (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/content_settings/content_settings_pref_provider_unittest.cc ('K') | « chrome/browser/content_settings/content_settings_pref_provider_unittest.cc ('k') | chrome/browser/notifications/notification_permission_context_unittest.cc » ('j') | components/content_settings/core/browser/content_settings_pref.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_permission_context.h

diff --git a/chrome/browser/notifications/notification_permission_context.h b/chrome/browser/notifications/notification_permission_context.h

index fb30d228842e4790f4ff28fdf46453971433b6d8..664c3ace0a2f92e264af41ad576284c770385325 100644

--- a/chrome/browser/notifications/notification_permission_context.h

+++ b/chrome/browser/notifications/notification_permission_context.h

@@ -26,6 +26,8 @@ class NotificationPermissionContext : public PermissionContextBase {

IgnoresEmbedderOrigin);

FRIEND_TEST_ALL_PREFIXES(NotificationPermissionContextTest,

NoSecureOriginRequirement);

+ FRIEND_TEST_ALL_PREFIXES(NotificationPermissionContextTest,

+ NotInheritedInIncognito);

// PermissionContextBase implementation.

void UpdateContentSetting(const GURL& requesting_origin,