Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1442013004: Use GN response files for devtools .grd (Closed)

Created:
5 years, 1 month ago by brettw
Modified:
5 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, caseq+blink_chromium.org, tfarina, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use GN response files for devtools .grd Eliminates the write_file call for making the debug devtools grd files by using a GN response file. This was made more complicated by the GYP and GN response files having different formats, so it now supports two different arguments. Further, in the normal (non debugging devtools) case, the response file is empty which GN interprets as "don't use a response file" and things get confused. As a result, the file list argument to the script is now optional. The script takes multiple categories of variable length files. This means that the normal OptionParser doesn't work well and I had to enhance the already complicated parsing. Fixes a typo in a GN error message I noticed. Committed: https://crrev.com/7cf73b7282dad450109b3eab2db79825cf03a4e0 Cr-Commit-Position: refs/heads/master@{#359634}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -18 lines) Patch
M third_party/WebKit/Source/devtools/BUILD.gn View 4 chunks +12 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/generate_devtools_grd.py View 2 chunks +28 lines, -5 lines 0 comments Download
M tools/gn/action_target_generator.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
brettw
5 years, 1 month ago (2015-11-13 18:24:27 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442013004/1
5 years, 1 month ago (2015-11-13 18:24:56 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-13 20:12:02 UTC) #7
Dirk Pranke
lgtm
5 years, 1 month ago (2015-11-13 20:34:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442013004/1
5 years, 1 month ago (2015-11-13 20:47:05 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 21:07:22 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 21:08:05 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7cf73b7282dad450109b3eab2db79825cf03a4e0
Cr-Commit-Position: refs/heads/master@{#359634}

Powered by Google App Engine
This is Rietveld 408576698