Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: tools/gn/action_target_generator.cc

Issue 1442013004: Use GN response files for devtools .grd (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/scripts/generate_devtools_grd.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/action_target_generator.cc
diff --git a/tools/gn/action_target_generator.cc b/tools/gn/action_target_generator.cc
index b2d7e2757a5059397cf32089b2ddecd028f8114c..6f962b6dd2a4379fe0576baa4422ca7165364cfb 100644
--- a/tools/gn/action_target_generator.cc
+++ b/tools/gn/action_target_generator.cc
@@ -85,9 +85,9 @@ void ActionTargetGenerator::DoRun() {
return;
}
if (!target_->action_values().uses_rsp_file() && has_rsp_file_name) {
- *err_ = Err(function_call_, "Missing response_file_content definition.",
+ *err_ = Err(function_call_, "Missing response_file_contents definition.",
"This target uses {{response_file_name}} in the args, but does not\n"
- "define response_file_content which means the response file\n"
+ "define response_file_contents which means the response file\n"
"will be empty.");
return;
}
« no previous file with comments | « third_party/WebKit/Source/devtools/scripts/generate_devtools_grd.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698