Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(18)

Issue 1441683004: AppCache: Use WeakPtr<> to fix a potential uaf bug. (Closed)

Created:
3 years, 9 months ago by michaeln
Modified:
3 years, 9 months ago
Reviewers:
gzobqq
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

AppCache: Use WeakPtr<> to fix a potential uaf bug. BUG=554908 Committed: https://crrev.com/4b5eefe562bd45c059f5dd93079450db5610788a Cr-Commit-Position: refs/heads/master@{#359930}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M content/browser/appcache/appcache_dispatcher_host.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/appcache/appcache_dispatcher_host.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
michaeln
ptal, this doesn't take care of the broader underlying issue, that's for another cl
3 years, 9 months ago (2015-11-13 00:00:06 UTC) #4
michaeln
https://codereview.chromium.org/1441683004/diff/1/content/browser/appcache/appcache_dispatcher_host.h File content/browser/appcache/appcache_dispatcher_host.h (right): https://codereview.chromium.org/1441683004/diff/1/content/browser/appcache/appcache_dispatcher_host.h#newcode12 content/browser/appcache/appcache_dispatcher_host.h:12: #include "base/process/process.h" i'll add the include here too
3 years, 9 months ago (2015-11-13 00:02:39 UTC) #5
michaeln
ping
3 years, 9 months ago (2015-11-16 19:05:24 UTC) #6
gzobqq
Sorry, missed this. LGTM
3 years, 9 months ago (2015-11-16 19:20:52 UTC) #7
michaeln
np thnx
3 years, 9 months ago (2015-11-16 20:14:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441683004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441683004/20001
3 years, 9 months ago (2015-11-16 20:16:16 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 9 months ago (2015-11-16 21:49:22 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2015-11-16 21:50:18 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4b5eefe562bd45c059f5dd93079450db5610788a
Cr-Commit-Position: refs/heads/master@{#359930}

Powered by Google App Engine
This is Rietveld 408576698