Restore feature defines argument.

tools/dom/scripts/fremontcutbuilder.py

Index: tools/dom/scripts/fremontcutbuilder.py
diff --git a/tools/dom/scripts/fremontcutbuilder.py b/tools/dom/scripts/fremontcutbuilder.py
index 98e65b43db08f8cbcbe4be2f54186b3a53133ad1..c7da849c029db9921b6dc5334888ee64e80813a6 100755
--- a/tools/dom/scripts/fremontcutbuilder.py
+++ b/tools/dom/scripts/fremontcutbuilder.py
@@ -47,7 +47,7 @@ FEATURE_DEFINES = [
     'ENABLE_WEBGL',
 ]
 
-def build_database(idl_files, database_dir, parallel=False):
+def build_database(idl_files, database_dir, feature_defs=None, parallel=False):

[podivilov1, 2013/04/26 08:11:23]

nit: feature_defines

[Anton Muhin, 2013/04/26 08:25:49]

Done.

   """This code reconstructs the FremontCut IDL database from W3C,
   WebKit and Dart IDL files."""
   current_dir = os.path.dirname(__file__)
@@ -68,10 +68,13 @@ def build_database(idl_files, database_dir, parallel=False):
   # generation.  We need to recheck this periodically for now.
   webkit_defines = [ 'LANGUAGE_DART', 'LANGUAGE_JAVASCRIPT' ]
 
+  if feature_defs is None:
+    feature_defs = FEATURE_DEFINES

[podivilov1, 2013/04/26 08:10:30]

Maybe make FEATURE_DEFINES a default?

[Anton Muhin, 2013/04/26 08:25:49]

Usually it's not recommended to have mutable objects as default in python as if
you mutate it, those mutations persist.

Yes, we're in full control here, but maybe follow common practices?

+
   webkit_options = databasebuilder.DatabaseBuilderOptions(
       idl_syntax=idlparser.WEBKIT_SYNTAX,
       # TODO(vsm): What else should we define as on when processing IDL?
-      idl_defines=webkit_defines + FEATURE_DEFINES,
+      idl_defines=webkit_defines + feature_defs,
       source='WebKit',
       source_attributes={'revision': webkit_revision})