Restore feature defines argument.

tools/dom/scripts/fremontcutbuilder.py

 #!/usr/bin/python
 # Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 import database
 import databasebuilder
 import idlparser
 import logging.config
 import os.path
@@ skipping 29 matching lines @@
     'ENABLE_NOTIFICATIONS',
     'ENABLE_PAGE_POPUP',
     'ENABLE_SHARED_WORKERS',
     'ENABLE_SVG',
     'ENABLE_SVG_FONTS',
     'ENABLE_VIDEO',
     'ENABLE_WEB_AUDIO',
     'ENABLE_WEBGL',
 ]
 
-def build_database(idl_files, database_dir, parallel=False):
+def build_database(idl_files, database_dir, feature_defs=None, parallel=False):

[podivilov1, 2013/04/26 08:11:23]

nit: feature_defines

[Anton Muhin, 2013/04/26 08:25:49]

Done.

   """This code reconstructs the FremontCut IDL database from W3C,
   WebKit and Dart IDL files."""
   current_dir = os.path.dirname(__file__)
   logging.config.fileConfig(os.path.join(current_dir, "logging.conf"))
 
   db = database.Database(database_dir)
 
   # Delete all existing IDLs in the DB.
   db.Delete()
 
   builder = databasebuilder.DatabaseBuilder(db)
 
   # TODO(vsm): Move this to a README.
   # This is the Dart SVN revision.
   webkit_revision = '1060'
 
   # TODO(vsm): Reconcile what is exposed here and inside WebKit code
   # generation.  We need to recheck this periodically for now.
   webkit_defines = [ 'LANGUAGE_DART', 'LANGUAGE_JAVASCRIPT' ]
 
+  if feature_defs is None:
+    feature_defs = FEATURE_DEFINES

[podivilov1, 2013/04/26 08:10:30]

Maybe make FEATURE_DEFINES a default?

[Anton Muhin, 2013/04/26 08:25:49]

Usually it's not recommended to have mutable objects as default in python as if
you mutate it, those mutations persist.

Yes, we're in full control here, but maybe follow common practices?

+
   webkit_options = databasebuilder.DatabaseBuilderOptions(
       idl_syntax=idlparser.WEBKIT_SYNTAX,
       # TODO(vsm): What else should we define as on when processing IDL?
-      idl_defines=webkit_defines + FEATURE_DEFINES,
+      idl_defines=webkit_defines + feature_defs,
       source='WebKit',
       source_attributes={'revision': webkit_revision})
 
   # Import WebKit IDLs.
   builder.import_idl_files(idl_files, webkit_options, parallel)
 
   # Import Dart idl:
   dart_options = databasebuilder.DatabaseBuilderOptions(
     idl_syntax=idlparser.FREMONTCUT_SYNTAX,
     source='Dart',
@@ skipping 56 matching lines @@
       if ext == '.idl':
         idl_files.append(file_name)
 
   os.path.walk(webcore_dir, visitor, webcore_dir)
 
   database_dir = os.path.join(current_dir, '..', 'database')
   return build_database(idl_files, database_dir, parallel=parallel)
 
 if __name__ == '__main__':
   sys.exit(main())