Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1424)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1441473004: Fix typos in BUILD.gn. (Closed)

Created:
5 years, 1 month ago by Oliver Chang
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix typos in BUILD.gn. Accidentally reverted this while rebasing another CL. TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/4274ea205ca2219f6a4cfc54025284c1aa3b14b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Oliver Chang
TBR
5 years, 1 month ago (2015-11-12 23:48:46 UTC) #3
Oliver Chang
Committed patchset #1 (id:1) manually as 4274ea205ca2219f6a4cfc54025284c1aa3b14b8 (presubmit successful).
5 years, 1 month ago (2015-11-12 23:49:14 UTC) #4
Lei Zhang
lgtm
5 years, 1 month ago (2015-11-12 23:50:47 UTC) #5
Lei Zhang
5 years, 1 month ago (2015-11-13 05:09:36 UTC) #6
Message was sent while issue was closed. 
Don't forget the XFA merge.

Powered by Google App Engine
This is Rietveld 408576698