Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: src/heap/spaces.cc

Issue 1441453002: Avoid manual object's body traversal in GC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments + removed HeapObject::ContentType() Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/mark-compact.cc ('k') | src/heap/store-buffer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/spaces.cc
diff --git a/src/heap/spaces.cc b/src/heap/spaces.cc
index a5e2760bb09d0004cfc8dec007121f946fda583c..16c84b05822cd48fdc1afdfd7d296c20b12252b8 100644
--- a/src/heap/spaces.cc
+++ b/src/heap/spaces.cc
@@ -3205,11 +3205,6 @@ void LargeObjectSpace::Verify() {
CHECK(map->IsMap());
CHECK(heap()->map_space()->Contains(map));
- // Double unboxing in LO space is not allowed. This would break the
- // lookup mechanism for store and slot buffer entries which use the
- // page header tag.
- CHECK(object->ContentType() != HeapObjectContents::kMixedValues);
Igor Sheludko 2015/11/13 17:35:18 As discussed offline I'm removing this check becau
Hannes Payer (out of office) 2015/11/13 18:54:38 Acknowledged.
-
// We have only code, sequential strings, external strings
// (sequential strings that have been morphed into external
// strings), fixed arrays, byte arrays, and constant pool arrays in the
« no previous file with comments | « src/heap/mark-compact.cc ('k') | src/heap/store-buffer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698