Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: src/heap/spaces.cc

Issue 1441453002: Avoid manual object's body traversal in GC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments + removed HeapObject::ContentType() Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap/mark-compact.cc ('k') | src/heap/store-buffer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/heap/spaces.h" 5 #include "src/heap/spaces.h"
6 6
7 #include "src/base/bits.h" 7 #include "src/base/bits.h"
8 #include "src/base/platform/platform.h" 8 #include "src/base/platform/platform.h"
9 #include "src/full-codegen/full-codegen.h" 9 #include "src/full-codegen/full-codegen.h"
10 #include "src/heap/slots-buffer.h" 10 #include "src/heap/slots-buffer.h"
(...skipping 3187 matching lines...) Expand 10 before | Expand all | Expand 10 after
3198 HeapObject* object = chunk->GetObject(); 3198 HeapObject* object = chunk->GetObject();
3199 Page* page = Page::FromAddress(object->address()); 3199 Page* page = Page::FromAddress(object->address());
3200 CHECK(object->address() == page->area_start()); 3200 CHECK(object->address() == page->area_start());
3201 3201
3202 // The first word should be a map, and we expect all map pointers to be 3202 // The first word should be a map, and we expect all map pointers to be
3203 // in map space. 3203 // in map space.
3204 Map* map = object->map(); 3204 Map* map = object->map();
3205 CHECK(map->IsMap()); 3205 CHECK(map->IsMap());
3206 CHECK(heap()->map_space()->Contains(map)); 3206 CHECK(heap()->map_space()->Contains(map));
3207 3207
3208 // Double unboxing in LO space is not allowed. This would break the
3209 // lookup mechanism for store and slot buffer entries which use the
3210 // page header tag.
3211 CHECK(object->ContentType() != HeapObjectContents::kMixedValues);
Igor Sheludko 2015/11/13 17:35:18 As discussed offline I'm removing this check becau
Hannes Payer (out of office) 2015/11/13 18:54:38 Acknowledged.
3212
3213 // We have only code, sequential strings, external strings 3208 // We have only code, sequential strings, external strings
3214 // (sequential strings that have been morphed into external 3209 // (sequential strings that have been morphed into external
3215 // strings), fixed arrays, byte arrays, and constant pool arrays in the 3210 // strings), fixed arrays, byte arrays, and constant pool arrays in the
3216 // large object space. 3211 // large object space.
3217 CHECK(object->IsCode() || object->IsSeqString() || 3212 CHECK(object->IsCode() || object->IsSeqString() ||
3218 object->IsExternalString() || object->IsFixedArray() || 3213 object->IsExternalString() || object->IsFixedArray() ||
3219 object->IsFixedDoubleArray() || object->IsByteArray()); 3214 object->IsFixedDoubleArray() || object->IsByteArray());
3220 3215
3221 // The object itself should look OK. 3216 // The object itself should look OK.
3222 object->ObjectVerify(); 3217 object->ObjectVerify();
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
3298 object->ShortPrint(); 3293 object->ShortPrint();
3299 PrintF("\n"); 3294 PrintF("\n");
3300 } 3295 }
3301 printf(" --------------------------------------\n"); 3296 printf(" --------------------------------------\n");
3302 printf(" Marked: %x, LiveCount: %x\n", mark_size, LiveBytes()); 3297 printf(" Marked: %x, LiveCount: %x\n", mark_size, LiveBytes());
3303 } 3298 }
3304 3299
3305 #endif // DEBUG 3300 #endif // DEBUG
3306 } // namespace internal 3301 } // namespace internal
3307 } // namespace v8 3302 } // namespace v8
OLDNEW
« no previous file with comments | « src/heap/mark-compact.cc ('k') | src/heap/store-buffer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698