Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: Source/core/animation/AnimatableShapeValue.cpp

Issue 144143005: Preserve shape-box order in non-computed values (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updating patch to trunk Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/AnimatableShapeValue.cpp
diff --git a/Source/core/animation/AnimatableShapeValue.cpp b/Source/core/animation/AnimatableShapeValue.cpp
index 1742bac1fbc25c8cf46b2365dfdd2f9e80d3ea89..e661e9e907304d0dcad71d8ae8be5b1cfe062c2a 100644
--- a/Source/core/animation/AnimatableShapeValue.cpp
+++ b/Source/core/animation/AnimatableShapeValue.cpp
@@ -37,7 +37,9 @@ bool AnimatableShapeValue::usesDefaultInterpolationWith(const AnimatableValue* v
{
const AnimatableShapeValue* shapeValue = toAnimatableShapeValue(value);
- if (m_shape->type() != ShapeValue::Shape || shapeValue->m_shape->type() != ShapeValue::Shape)
+ if (m_shape->type() != ShapeValue::Shape
+ || shapeValue->m_shape->type() != ShapeValue::Shape
+ || m_shape->layoutBox() != shapeValue->m_shape->layoutBox())
return true;
const BasicShape* fromShape = this->m_shape->shape();
@@ -54,7 +56,7 @@ PassRefPtr<AnimatableValue> AnimatableShapeValue::interpolateTo(const Animatable
const AnimatableShapeValue* shapeValue = toAnimatableShapeValue(value);
const BasicShape* fromShape = this->m_shape->shape();
const BasicShape* toShape = shapeValue->m_shape->shape();
- return AnimatableShapeValue::create(ShapeValue::createShapeValue(toShape->blend(fromShape, fraction)).get());
+ return AnimatableShapeValue::create(ShapeValue::createShapeValue(toShape->blend(fromShape, fraction), shapeValue->m_shape->layoutBox()).get());
}
bool AnimatableShapeValue::equalTo(const AnimatableValue* value) const
« no previous file with comments | « Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl ('k') | Source/core/animation/AnimatableValueTestHelperTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698