Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: Source/core/animation/AnimatableShapeValue.cpp

Issue 144143005: Preserve shape-box order in non-computed values (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updating patch to trunk Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 19 matching lines...) Expand all
30 30
31 #include "config.h" 31 #include "config.h"
32 #include "core/animation/AnimatableShapeValue.h" 32 #include "core/animation/AnimatableShapeValue.h"
33 33
34 namespace WebCore { 34 namespace WebCore {
35 35
36 bool AnimatableShapeValue::usesDefaultInterpolationWith(const AnimatableValue* v alue) const 36 bool AnimatableShapeValue::usesDefaultInterpolationWith(const AnimatableValue* v alue) const
37 { 37 {
38 const AnimatableShapeValue* shapeValue = toAnimatableShapeValue(value); 38 const AnimatableShapeValue* shapeValue = toAnimatableShapeValue(value);
39 39
40 if (m_shape->type() != ShapeValue::Shape || shapeValue->m_shape->type() != S hapeValue::Shape) 40 if (m_shape->type() != ShapeValue::Shape
41 || shapeValue->m_shape->type() != ShapeValue::Shape
42 || m_shape->layoutBox() != shapeValue->m_shape->layoutBox())
41 return true; 43 return true;
42 44
43 const BasicShape* fromShape = this->m_shape->shape(); 45 const BasicShape* fromShape = this->m_shape->shape();
44 const BasicShape* toShape = shapeValue->m_shape->shape(); 46 const BasicShape* toShape = shapeValue->m_shape->shape();
45 47
46 return !fromShape->canBlend(toShape); 48 return !fromShape->canBlend(toShape);
47 } 49 }
48 50
49 PassRefPtr<AnimatableValue> AnimatableShapeValue::interpolateTo(const Animatable Value* value, double fraction) const 51 PassRefPtr<AnimatableValue> AnimatableShapeValue::interpolateTo(const Animatable Value* value, double fraction) const
50 { 52 {
51 if (usesDefaultInterpolationWith(value)) 53 if (usesDefaultInterpolationWith(value))
52 return defaultInterpolateTo(this, value, fraction); 54 return defaultInterpolateTo(this, value, fraction);
53 55
54 const AnimatableShapeValue* shapeValue = toAnimatableShapeValue(value); 56 const AnimatableShapeValue* shapeValue = toAnimatableShapeValue(value);
55 const BasicShape* fromShape = this->m_shape->shape(); 57 const BasicShape* fromShape = this->m_shape->shape();
56 const BasicShape* toShape = shapeValue->m_shape->shape(); 58 const BasicShape* toShape = shapeValue->m_shape->shape();
57 return AnimatableShapeValue::create(ShapeValue::createShapeValue(toShape->bl end(fromShape, fraction)).get()); 59 return AnimatableShapeValue::create(ShapeValue::createShapeValue(toShape->bl end(fromShape, fraction), shapeValue->m_shape->layoutBox()).get());
58 } 60 }
59 61
60 bool AnimatableShapeValue::equalTo(const AnimatableValue* value) const 62 bool AnimatableShapeValue::equalTo(const AnimatableValue* value) const
61 { 63 {
62 const ShapeValue* shape = toAnimatableShapeValue(value)->m_shape.get(); 64 const ShapeValue* shape = toAnimatableShapeValue(value)->m_shape.get();
63 return m_shape == shape || (m_shape && shape && *m_shape == *shape); 65 return m_shape == shape || (m_shape && shape && *m_shape == *shape);
64 } 66 }
65 67
66 } 68 }
OLDNEW
« no previous file with comments | « Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl ('k') | Source/core/animation/AnimatableValueTestHelperTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698