Issue 144143005: Preserve shape-box order in non-computed values

Issue 144143005: Preserve shape-box order in non-computed values (Closed)

Created:
6 years, 11 months ago by Bear Travis

Modified:
6 years, 9 months ago

Reviewers:
leviw_travelin_and_unemployed, eseidel, Julien - ping for review, ojan

CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dsinclair, zoltan1, eae+blinkwatch, dglazkov+blink, leviw+renderwatch, dstockwell, Timothy Loh, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, bemjb+rendering_chromium.org, Steve Block, dino_apple.com, Eric Willigers, leviw_travelin_and_unemployed

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Preserve shape-box order in non-computed values When a shape and box are supplied for a shape-property, the order they are input should be preserved in output from the CSSOM. This patch parses the shape and box values as a CSSValueList to preserve that ordering, and removes the need for BasicShapes to have a sizing box. BUG=322165 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168477

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -85 lines)			Patch
M	LayoutTests/fast/shapes/parsing/parsing-shape-inside-expected.txt	View	1 2 3 4 5 6 7	1 chunk	+4 lines, -4 lines	0 comments	Download
M	LayoutTests/fast/shapes/parsing/parsing-shape-outside-expected.txt	View	1 2 3 4 5 6 7	1 chunk	+4 lines, -4 lines	0 comments	Download
M	LayoutTests/fast/shapes/parsing/parsing-test-utils.js	View	1 2 3 4 5 6 7	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl	View	1 2 3 4 5 6 7	1 chunk	+21 lines, -8 lines	0 comments	Download
M	Source/core/animation/AnimatableShapeValue.cpp	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	Source/core/animation/AnimatableValueTestHelperTest.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/BasicShapeFunctions.cpp	View	1 2 3 4 5 6 7	2 chunks	+0 lines, -6 lines	0 comments	Download
M	Source/core/css/CSSComputedStyleDeclaration.cpp	View	1 2 3 4 5 6 7	2 chunks	+22 lines, -24 lines	0 comments	Download
M	Source/core/css/parser/CSSPropertyParser.h	View	1 2 3 4 5 6 7	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/css/parser/CSSPropertyParser.cpp	View	1 2 3 4 5 6 7	1 chunk	+25 lines, -22 lines	0 comments	Download
M	Source/core/rendering/style/BasicShapes.h	View	1 2 3 4 5 6 7	1 chunk	+0 lines, -6 lines	0 comments	Download
M	Source/core/rendering/style/ShapeValue.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download