Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Issue 14413014: Remove -webkit-appearance:default-button. This was only used in Safari. (Closed)

Created:
7 years, 8 months ago by Robert Sesek
Modified:
7 years, 8 months ago
CC:
blink-reviews, jeez, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, abarth-chromium
Visibility:
Public.

Description

Remove -webkit-appearance:default-button. This was only used in Safari. This was added to WebKit at r32881 and r35950. When ApplicationChromeMode was removed in Blink r148011 this became dead code. Also removes a call into WebKitSystemInterface. BUG=101156 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149201

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : Rebase #

Patch Set 4 : Remove an isDefault #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -86 lines) Patch
M Source/core/css/CSSPrimitiveValueMappings.h View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/ThemeTypes.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/platform/mac/ThemeMac.mm View 1 2 3 4 10 chunks +6 lines, -37 lines 0 comments Download
M Source/core/platform/mac/WebCoreSystemInterface.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderButton.h View 1 2 3 4 2 chunks +0 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderButton.cpp View 1 2 3 4 3 chunks +0 lines, -16 lines 0 comments Download
M Source/core/rendering/RenderTheme.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 1 2 3 4 9 chunks +0 lines, -14 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumDefault.cpp View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderThemeChromiumMac.mm View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderThemeChromiumWin.cpp View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Robert Sesek
abarth: let me know if there's somebody better to send this to.
7 years, 8 months ago (2013-04-23 18:16:32 UTC) #1
abarth-chromium
Ojan is likely a better reviewer for this CL.
7 years, 8 months ago (2013-04-23 20:54:44 UTC) #2
eseidel
7 years, 8 months ago (2013-04-24 08:13:59 UTC) #3
tkent
lgtm
7 years, 8 months ago (2013-04-24 08:30:44 UTC) #4
Robert Sesek
7 years, 8 months ago (2013-04-26 14:43:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 manually as r149201 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698