Remove -webkit-appearance:default-button. This was only used in Safari.

Source/core/platform/mac/ThemeMac.mm

 /*
  * Copyright (C) 2008, 2010, 2011, 2012 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 12 matching lines @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
  */
 
 #import "config.h"
 #import "ThemeMac.h"
 
 #import <Carbon/Carbon.h>
 #import "BlockExceptions.h"
 #import "LocalCurrentGraphicsContext.h"
 #import "WebCoreNSCellExtras.h"
-#import "WebCoreSystemInterface.h"
 #import "core/platform/ScrollView.h"
 #import "core/platform/graphics/GraphicsContext.h"
 #include <wtf/StdLibExtras.h>
 
 using namespace std;
 
 NSRect focusRingClipRect;
 
 // This is a view whose sole purpose is to tell AppKit that it's flipped.
 @interface WebCoreFlippedView : NSControl
@@ skipping 39 matching lines @@
 - (NSString*)webCoreFamilyName
 {
     if ([[self familyName] hasPrefix:@"."])
         return [self fontName];
 
     return [self familyName];
 }
 
 @end
 
-// FIXME: Default buttons really should be more like push buttons and not like buttons.
-
 namespace WebCore {
 
 enum {
     topMargin,
     rightMargin,
     bottomMargin,
     leftMargin
 };
 
 Theme* platformTheme()
@@ skipping 297 matching lines @@
 {
     static const int margins[3][4] =
     {
         { 4, 6, 7, 6 },
         { 4, 5, 6, 5 },
         { 0, 1, 1, 1 },
     };
     return margins[controlSize];
 }
 
-enum ButtonCellType { NormalButtonCell, DefaultButtonCell };
-
-static NSButtonCell *leakButtonCell(ButtonCellType type)
-{
-    NSButtonCell *cell = [[NSButtonCell alloc] init];
-    [cell setTitle:nil];
-    [cell setButtonType:NSMomentaryPushInButton];
-    if (type == DefaultButtonCell)
-        [cell setKeyEquivalent:@"\r"];
-    return cell;
-}
-
 static void setUpButtonCell(NSButtonCell *cell, ControlPart part, ControlStates states, const IntRect& zoomedRect, float zoomFactor)
 {
     // Set the control size based off the rectangle we're painting into.
     const IntSize* sizes = buttonSizes();
     if (part == SquareButtonPart || zoomedRect.height() > buttonSizes()[NSRegularControlSize].height() * zoomFactor) {
         // Use the square button
         if ([cell bezelStyle] != NSShadowlessSquareBezelStyle)
             [cell setBezelStyle:NSShadowlessSquareBezelStyle];
     } else if ([cell bezelStyle] != NSRoundedBezelStyle)
         [cell setBezelStyle:NSRoundedBezelStyle];
 
     setControlSize(cell, sizes, zoomedRect.size(), zoomFactor);
 
     // Update the various states we respond to.
     updateStates(cell, states);
 }
 
 static NSButtonCell *button(ControlPart part, ControlStates states, const IntRect& zoomedRect, float zoomFactor)
 {
-    NSButtonCell *cell;
-    if (states & DefaultState) {
-        static NSButtonCell *defaultCell = leakButtonCell(DefaultButtonCell);
-        cell = defaultCell;
-    } else {
-        static NSButtonCell *normalCell = leakButtonCell(NormalButtonCell);
-        cell = normalCell;
+    static NSButtonCell *cell = nil;
+    if (!cell) {
+        cell = [[NSButtonCell alloc] init];
+        [cell setTitle:nil];
+        [cell setButtonType:NSMomentaryPushInButton];
     }
-    setUpButtonCell(cell, part, states, zoomedRect, zoomFactor);    
+    setUpButtonCell(cell, part, states, zoomedRect, zoomFactor);
     return cell;
 }
 
 static void paintButton(ControlPart part, ControlStates states, GraphicsContext* context, const IntRect& zoomedRect, float zoomFactor, ScrollView* scrollView)
 {
     BEGIN_BLOCK_OBJC_EXCEPTIONS
     
     // Determine the width and height needed for the control and prepare the cell for painting.
     NSButtonCell *buttonCell = button(part, states, zoomedRect, zoomFactor);
     GraphicsContextStateSaver stateSaver(*context);
@@ skipping 18 matching lines @@
             inflatedRect.setHeight(inflatedRect.height() / zoomFactor);
             context->translate(inflatedRect.x(), inflatedRect.y());
             context->scale(FloatSize(zoomFactor, zoomFactor));
             context->translate(-inflatedRect.x(), -inflatedRect.y());
         }
     } 
 
     LocalCurrentGraphicsContext localContext(context);
     NSView *view = ThemeMac::ensuredView(scrollView);
     NSWindow *window = [view window];
-    NSButtonCell *previousDefaultButtonCell = [window defaultButtonCell];
-
-    if (states & DefaultState) {
-        [window setDefaultButtonCell:buttonCell];
-        WKAdvanceDefaultButtonPulseAnimation(buttonCell);
-    } else if ([previousDefaultButtonCell isEqual:buttonCell])
-        [window setDefaultButtonCell:nil];
 
     [buttonCell drawWithFrame:NSRect(inflatedRect) inView:view];
 #if !BUTTON_CELL_DRAW_WITH_FRAME_DRAWS_FOCUS_RING
     if (states & FocusState)
         [buttonCell _web_drawFocusRingWithFrame:NSRect(inflatedRect) inView:view];
 #endif
     [buttonCell setControlView:nil];
 
-    if (![previousDefaultButtonCell isEqual:buttonCell])
-        [window setDefaultButtonCell:previousDefaultButtonCell];
-
     END_BLOCK_OBJC_EXCEPTIONS
 }
 
 // Stepper
 
 static const IntSize* stepperSizes()
 {
     static const IntSize sizes[3] = { IntSize(19, 27), IntSize(15, 22), IntSize(13, 15) };
     return sizes;
 }
@@ skipping 111 matching lines @@
             return sizeFromNSControlSize(stepperControlSizeForFont(font), zoomedSize, zoomFactor, stepperSizes());
         default:
             return zoomedSize;
     }
 }
 
 LengthSize ThemeMac::minimumControlSize(ControlPart part, const Font& font, float zoomFactor) const
 {
     switch (part) {
         case SquareButtonPart:
-        case DefaultButtonPart:
         case ButtonPart:
             return LengthSize(Length(0, Fixed), Length(static_cast<int>(15 * zoomFactor), Fixed));
         case InnerSpinButtonPart:{
             IntSize base = stepperSizes()[NSMiniControlSize];
             return LengthSize(Length(static_cast<int>(base.width() * zoomFactor), Fixed),
                               Length(static_cast<int>(base.height() * zoomFactor), Fixed));
         }
         default:
             return Theme::minimumControlSize(part, font, zoomFactor);
     }
 }
 
 LengthBox ThemeMac::controlBorder(ControlPart part, const Font& font, const LengthBox& zoomedBox, float zoomFactor) const
 {
     switch (part) {
         case SquareButtonPart:
-        case DefaultButtonPart:
         case ButtonPart:
             return LengthBox(0, zoomedBox.right().value(), 0, zoomedBox.left().value());
         default:
             return Theme::controlBorder(part, font, zoomedBox, zoomFactor);
     }
 }
 
 LengthBox ThemeMac::controlPadding(ControlPart part, const Font& font, const LengthBox& zoomedBox, float zoomFactor) const
 {
     switch (part) {
@@ skipping 31 matching lines @@
             // shadow".  We don't consider this part of the bounds of the control in WebKit.
             NSCell *cell = radio(states, zoomedRect, zoomFactor);
             NSControlSize controlSize = [cell controlSize];
             IntSize zoomedSize = radioSizes()[controlSize];
             zoomedSize.setHeight(zoomedSize.height() * zoomFactor);
             zoomedSize.setWidth(zoomedSize.width() * zoomFactor);
             zoomedRect = inflateRect(zoomedRect, zoomedSize, radioMargins(controlSize), zoomFactor);
             break;
         }
         case PushButtonPart:
-        case DefaultButtonPart:
         case ButtonPart: {
             NSButtonCell *cell = button(part, states, zoomedRect, zoomFactor);
             NSControlSize controlSize = [cell controlSize];
 
             // We inflate the rect as needed to account for the Aqua button's shadow.
             if ([cell bezelStyle] == NSRoundedBezelStyle) {
                 IntSize zoomedSize = buttonSizes()[controlSize];
                 zoomedSize.setHeight(zoomedSize.height() * zoomFactor);
                 zoomedSize.setWidth(zoomedRect.width()); // Buttons don't ever constrain width, so the zoomed width can just be honored.
                 zoomedRect = inflateRect(zoomedRect, zoomedSize, buttonMargins(controlSize), zoomFactor);
@@ skipping 18 matching lines @@
 void ThemeMac::paint(ControlPart part, ControlStates states, GraphicsContext* context, const IntRect& zoomedRect, float zoomFactor, ScrollView* scrollView) const
 {
     switch (part) {
         case CheckboxPart:
             paintCheckbox(states, context, zoomedRect, zoomFactor, scrollView);
             break;
         case RadioPart:
             paintRadio(states, context, zoomedRect, zoomFactor, scrollView);
             break;
         case PushButtonPart:
-        case DefaultButtonPart:
         case ButtonPart:
         case SquareButtonPart:
             paintButton(part, states, context, zoomedRect, zoomFactor, scrollView);
             break;
         case InnerSpinButtonPart:
             paintStepper(states, context, zoomedRect, zoomFactor, scrollView);
             break;
         default:
             break;
     }
 }
 
 }