Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1697)

Unified Diff: android_webview/browser/aw_render_thread_context_provider.cc

Issue 1441273002: Android WebView: Crash on compositor context loss (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: don't lose on memory Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/browser/parent_output_surface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/aw_render_thread_context_provider.cc
diff --git a/android_webview/browser/aw_render_thread_context_provider.cc b/android_webview/browser/aw_render_thread_context_provider.cc
index 748de1f3e510d81c4d6b54beacd43cf4deb5acfa..acc6e36f290efc21c1408298a8eba6788a268c51 100644
--- a/android_webview/browser/aw_render_thread_context_provider.cc
+++ b/android_webview/browser/aw_render_thread_context_provider.cc
@@ -59,7 +59,7 @@ AwRenderThreadContextProvider::AwRenderThreadContextProvider(
gpu::gles2::ContextCreationAttribHelper attribs_for_gles2;
gpu_blink::WebGraphicsContext3DImpl::ConvertAttributes(attributes,
&attribs_for_gles2);
- attribs_for_gles2.lose_context_when_out_of_memory = true;
+ attribs_for_gles2.lose_context_when_out_of_memory = false;
no sievers 2015/11/18 23:50:20 nit: maybe put a comment that this is not our cont
context_.reset(gpu::GLInProcessContext::Create(
service,
« no previous file with comments | « no previous file | android_webview/browser/parent_output_surface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698