Android WebView: Crash on compositor context loss

android_webview/browser/aw_render_thread_context_provider.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/aw_render_thread_context_provider.h"
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/lazy_instance.h"
 #include "base/trace_event/trace_event.h"
@@ skipping 41 matching lines @@
 
   blink::WebGraphicsContext3D::Attributes attributes;
   attributes.antialias = false;
   attributes.depth = false;
   attributes.stencil = false;
   attributes.shareResources = true;
   attributes.noAutomaticFlushes = true;
   gpu::gles2::ContextCreationAttribHelper attribs_for_gles2;
   gpu_blink::WebGraphicsContext3DImpl::ConvertAttributes(attributes,
                                                          &attribs_for_gles2);
-  attribs_for_gles2.lose_context_when_out_of_memory = true;
+  attribs_for_gles2.lose_context_when_out_of_memory = false;

[no sievers, 2015/11/18 23:50:20]

nit: maybe put a comment that this is not our context but the framework's, so
not up to us to decide when to lose it

speaking of which: do we handle the framework allocating a new context?

 
   context_.reset(gpu::GLInProcessContext::Create(
       service,
       surface,
       surface->IsOffscreen(),
       gfx::kNullAcceleratedWidget,
       surface->GetSize(),
       NULL /* share_context */,
       false /* share_resources */,
       attribs_for_gles2,
@@ skipping 101 matching lines @@
 void AwRenderThreadContextProvider::OnLostContext() {
   DCHECK(main_thread_checker_.CalledOnValidThread());
 
   if (!lost_context_callback_.is_null())
     base::ResetAndReturn(&lost_context_callback_).Run();
   if (gr_context_)
     gr_context_->abandonContext();
 }
 
 }  // namespace android_webview