Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1441023002: Fix push/pop emit methods for ARM assembler. (Closed)

Created:
5 years, 1 month ago by Karl
Modified:
5 years, 1 month ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix push/pop emit methods for ARM assembler. These two methods introduce multiple instructions. Between each instruction a newline must be inserted, and a call to startNextInt(). This CL makes sure both cases are met. BUG=None R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=799ba673b3c130d9754104e1f1dfb5b8c652fe67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M src/IceInstARM32.cpp View 3 chunks +7 lines, -2 lines 0 comments Download
M tests_lit/assembler/arm32/mul.ll View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Karl
5 years, 1 month ago (2015-11-12 16:30:20 UTC) #3
Jim Stichnoth
LGTM, but be sure to compare notes with John who I believe also made a ...
5 years, 1 month ago (2015-11-12 17:50:45 UTC) #4
Karl
5 years, 1 month ago (2015-11-12 18:12:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
799ba673b3c130d9754104e1f1dfb5b8c652fe67 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698