Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: src/IceInstARM32.cpp

Issue 1441023002: Fix push/pop emit methods for ARM assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests_lit/assembler/arm32/mul.ll » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceInstARM32.cpp
diff --git a/src/IceInstARM32.cpp b/src/IceInstARM32.cpp
index 7363617c80e672d561a84cd371653dd4eb268951..5507b63fcffe938efd98d16cb7e21f3f473106c8 100644
--- a/src/IceInstARM32.cpp
+++ b/src/IceInstARM32.cpp
@@ -1117,9 +1117,9 @@ void InstARM32Pop::emit(const Cfg *Func) const {
for (const Operand *Op : Dests) {
if (isScalarIntegerType(Op->getType()))
continue;
- startNextInst(Func);
if (NeedNewline) {
Str << "\n";
+ startNextInst(Func);
NeedNewline = false;
}
Str << "\t"
@@ -1227,6 +1227,11 @@ void InstARM32Push::emit(const Cfg *Func) const {
Operand *Op = getSrc(i - 1);
if (isScalarIntegerType(Op->getType()))
continue;
+ if (NeedNewline) {
+ Str << "\n";
+ startNextInst(Func);
+ NeedNewline = false;
+ }
Str << "\t"
<< "vpush"
<< "\t{";
@@ -1235,9 +1240,9 @@ void InstARM32Push::emit(const Cfg *Func) const {
NeedNewline = true;
}
if (IntegerCount != 0) {
- startNextInst(Func);
if (NeedNewline) {
Str << "\n";
+ startNextInst(Func);
NeedNewline = false;
}
Str << "\t"
« no previous file with comments | « no previous file | tests_lit/assembler/arm32/mul.ll » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698