|
[webcrypto] Remove code supporting Key.algorithm.
Now the reflected Key.algorithm has ONLY a "name" property and nothing else.
The issue is that the spec [1] doesn't define what interfaces should be used to reflect back the Key's algorithm, and there are several interpretations.
Previously the Blink code was reflecting the same Algorithm as was used to import the key, or generate the key. This is awkward since it gives different parameters depending on whether the key was generated or imported (imported keys will not indicate RSA key sizes, DH groups, etc).
Rather than try to invent new interfaces for this purpose, this changelist limits Key.algorithm to JUST having a "name" property and no other parameters.
The intention is to add back a richer Key.algorithm once this has been added to the spec (so there is clarity on what the interface names should be, what normalizations to perform, and what properties to expose).
Until then, I am deleting the ambiguous code to make this more maintainable, and avoid exposing inconsistent key.algorithms to consumers of WebCrypto.
[1] https://dvcs.w3.org/hg/webcrypto-api/raw-file/tip/spec/Overview.html#key-interface
BUG= 245025
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165519
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+1 line, -1150 lines) |
Patch |
|
M |
LayoutTests/crypto/importKey.html
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
LayoutTests/crypto/importKey-expected.txt
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
LayoutTests/crypto/sign-verify.html
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
LayoutTests/crypto/sign-verify-expected.txt
|
View
|
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
|
M |
Source/bindings/bindings.gypi
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
D |
Source/bindings/v8/custom/V8AlgorithmCustom.cpp
|
View
|
|
1 chunk |
+0 lines, -78 lines |
0 comments
|
Download
|
|
D |
Source/modules/crypto/AesCbcParams.h
|
View
|
|
1 chunk |
+0 lines, -53 lines |
0 comments
|
Download
|
|
D |
Source/modules/crypto/AesCbcParams.cpp
|
View
|
|
1 chunk |
+0 lines, -54 lines |
0 comments
|
Download
|
|
D |
Source/modules/crypto/AesCbcParams.idl
|
View
|
|
1 chunk |
+0 lines, -35 lines |
0 comments
|
Download
|
|
D |
Source/modules/crypto/AesCtrParams.h
|
View
|
|
1 chunk |
+0 lines, -54 lines |
0 comments
|
Download
|
|
D |
Source/modules/crypto/AesCtrParams.cpp
|
View
|
|
1 chunk |
+0 lines, -59 lines |
0 comments
|
Download
|
|
D |
Source/modules/crypto/AesCtrParams.idl
|
View
|
|
1 chunk |
+0 lines, -36 lines |
0 comments
|
Download
|
|
D |
Source/modules/crypto/AesKeyGenParams.h
|
View
|
|
1 chunk |
+0 lines, -51 lines |
0 comments
|
Download
|
|
D |
Source/modules/crypto/AesKeyGenParams.cpp
|
View
|
|
1 chunk |
+0 lines, -50 lines |
0 comments
|
Download
|
|
D |
Source/modules/crypto/AesKeyGenParams.idl
|
View
|
|
1 chunk |
+0 lines, -35 lines |
0 comments
|
Download
|
|
M |
Source/modules/crypto/Algorithm.cpp
|
View
|
|
1 chunk |
+1 line, -33 lines |
0 comments
|
Download
|
|
M |
Source/modules/crypto/Algorithm.idl
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
D |
Source/modules/crypto/HmacKeyParams.h
|
View
|
|
1 chunk |
+0 lines, -55 lines |
0 comments
|
Download
|
|
D |
Source/modules/crypto/HmacKeyParams.cpp
|
View
|
|
1 chunk |
+0 lines, -58 lines |
0 comments
|
Download
|
|
D |
Source/modules/crypto/HmacKeyParams.idl
|
View
|
|
1 chunk |
+0 lines, -36 lines |
0 comments
|
Download
|
|
D |
Source/modules/crypto/HmacParams.h
|
View
|
|
1 chunk |
+0 lines, -53 lines |
0 comments
|
Download
|
|
D |
Source/modules/crypto/HmacParams.cpp
|
View
|
|
1 chunk |
+0 lines, -52 lines |
0 comments
|
Download
|
|
D |
Source/modules/crypto/HmacParams.idl
|
View
|
|
1 chunk |
+0 lines, -35 lines |
0 comments
|
Download
|
|
D |
Source/modules/crypto/RsaKeyGenParams.h
|
View
|
|
1 chunk |
+0 lines, -55 lines |
0 comments
|
Download
|
|
D |
Source/modules/crypto/RsaKeyGenParams.cpp
|
View
|
|
1 chunk |
+0 lines, -59 lines |
0 comments
|
Download
|
|
D |
Source/modules/crypto/RsaKeyGenParams.idl
|
View
|
|
1 chunk |
+0 lines, -36 lines |
0 comments
|
Download
|
|
D |
Source/modules/crypto/RsaSsaParams.h
|
View
|
|
1 chunk |
+0 lines, -53 lines |
0 comments
|
Download
|
|
D |
Source/modules/crypto/RsaSsaParams.cpp
|
View
|
|
1 chunk |
+0 lines, -52 lines |
0 comments
|
Download
|
|
D |
Source/modules/crypto/RsaSsaParams.idl
|
View
|
|
1 chunk |
+0 lines, -35 lines |
0 comments
|
Download
|
|
M |
Source/modules/modules.gypi
|
View
|
|
3 chunks |
+0 lines, -21 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|