Unify mc.exe calling in GN, set environment.

Unify mc.exe calling in GN, set environment.

There were previously two message compiler wrapper scripts which this unifies into one template and script in build.

Explicitly sets the environment block when running mc.exe. Currently GN sets this automatically but will soon stop doing this.

Committed: https://crrev.com/4744642adb27d4c27a8a0cd0e55e1fbeffc9803b
Cr-Commit-Position: refs/heads/master@{#359155}

[brettw, 2015-11-11 18:50:16]

Description was changed from

==========
Unify mc.exe calling in GN, set environment.

There were previously two message compiler wrapper scripts which this unifies
into one template and script in build.

Explicitly sets the environment block when running mc.exe. Currently GN sets
this automatically but will soon stop doing this.

BUG=
==========

to

==========
Unify mc.exe calling in GN, set environment.

There were previously two message compiler wrapper scripts which this unifies
into one template and script in build.

Explicitly sets the environment block when running mc.exe. Currently GN sets
this automatically but will soon stop doing this.
==========

[brettw, 2015-11-11 18:51:00]

brettw@chromium.org changed reviewers:
+ scottmg@chromium.org

[brettw, 2015-11-11 18:51:01]

I preserved the same arguments, base was using "-um" which I'm not sure is
required or not. If you know anything about this it would be nice.

[brettw, 2015-11-11 18:51:07]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-11 18:51:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1440693003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1440693003/1

[brettw, 2015-11-11 19:08:07]

brettw@chromium.org changed reviewers:
- scottmg@chromium.org

[Lei Zhang, 2015-11-11 19:29:06]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2015-11-11 19:29:07]

lgtm

https://codereview.chromium.org/1440693003/diff/1/build/win/message_compiler.py
File build/win/message_compiler.py (right):

https://codereview.chromium.org/1440693003/diff/1/build/win/message_compiler....
build/win/message_compiler.py:19: # mc writes to stderr, so this explicily
redirects to stdout and eats it.
typo: explicitly

[commit-bot: I haz the power, 2015-11-11 19:33:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-11 19:33:29]

Dry run: This issue passed the CQ dry run.

[brettw, 2015-11-11 20:25:17]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-11-11 20:25:17]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1440693003/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-11-11 20:26:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1440693003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1440693003/20001

[commit-bot: I haz the power, 2015-11-11 21:06:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-12 20:00:16]

Patchset 2 (id:??) landed as
https://crrev.com/4744642adb27d4c27a8a0cd0e55e1fbeffc9803b
Cr-Commit-Position: refs/heads/master@{#359155}