Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: base/trace_event/etw_manifest/BUILD.gn

Issue 1440693003: Unify mc.exe calling in GN, set environment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/trace_event/etw_manifest/BUILD/message_compiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/etw_manifest/BUILD.gn
diff --git a/base/trace_event/etw_manifest/BUILD.gn b/base/trace_event/etw_manifest/BUILD.gn
index f62e356b118ba343c540863123b28cdf96c90229..ed83aab0ed4fdb956de24d592e0113c02798bb0d 100644
--- a/base/trace_event/etw_manifest/BUILD.gn
+++ b/base/trace_event/etw_manifest/BUILD.gn
@@ -2,47 +2,19 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-assert(is_win, "This only runs on Windows.")
-
-# Makes the .h/.rc files from the .man file.
-action("chrome_events_win_generate") {
- visibility = [ ":*" ]
- script = "build/message_compiler.py"
-
- sources = [
- "chrome_events_win.man",
- ]
-
- outputs = [
- "$target_gen_dir/chrome_events_win.h",
- "$target_gen_dir/chrome_events_win.rc",
- ]
-
- args = [
- # Where to put the header.
- "-h",
- rebase_path("$target_gen_dir", root_build_dir),
+import("//build/win/message_compiler.gni")
- # Where to put the .rc file.
- "-r",
- rebase_path("$target_gen_dir", root_build_dir),
-
- # Generate the user-mode code.
- "-um",
- rebase_path("chrome_events_win.man", root_build_dir),
- ]
-}
+assert(is_win, "This only runs on Windows.")
-# Compile the generated files.
-source_set("chrome_events_win") {
+message_compiler("chrome_events_win") {
visibility = [
"//base/trace_event/*",
"//chrome:main_dll",
]
- sources = get_target_outputs(":chrome_events_win_generate")
-
- deps = [
- ":chrome_events_win_generate",
+ sources = [
+ "chrome_events_win.man",
]
+
+ user_mode_logging = true
}
« no previous file with comments | « no previous file | base/trace_event/etw_manifest/BUILD/message_compiler.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698