Use Node.isDocumentTypeNode more

Call this method to improve readability, rather than duplicating its implementation.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165861

[rwlbuis, 2014-01-24 20:04:52]

Simple removal patch.

[Inactive, 2014-01-24 20:14:50]

https://codereview.chromium.org/144063008/diff/1/Source/core/dom/Node.h
File Source/core/dom/Node.h (left):

https://codereview.chromium.org/144063008/diff/1/Source/core/dom/Node.h#oldco...
Source/core/dom/Node.h:476: bool isDocumentTypeNode() const { return nodeType()
== DOCUMENT_TYPE_NODE; }
Hmm. It could actually be used in:
- Source/core/dom/Range.cpp:        if (n->nodeType() ==
Node::DOCUMENT_TYPE_NODE) {
- Source/core/editing/markup.cpp:    if (nodeType != Node::DOCUMENT_NODE &&
nodeType != Node::DOCUMENT_TYPE_NODE)
- Source/core/dom/DocumentType.h:DEFINE_NODE_TYPE_CASTS(DocumentType, nodeType()
== Node::DOCUMENT_TYPE_NODE);

And would lead to slightly more readable code.

[rwlbuis, 2014-01-24 22:05:50]

On 2014/01/24 20:14:50, Chris Dumez wrote:
> https://codereview.chromium.org/144063008/diff/1/Source/core/dom/Node.h
> File Source/core/dom/Node.h (left):
> 
>
https://codereview.chromium.org/144063008/diff/1/Source/core/dom/Node.h#oldco...
> Source/core/dom/Node.h:476: bool isDocumentTypeNode() const { return
nodeType()
> == DOCUMENT_TYPE_NODE; }
> Hmm. It could actually be used in:
> - Source/core/dom/Range.cpp:        if (n->nodeType() ==
> Node::DOCUMENT_TYPE_NODE) {
> - Source/core/editing/markup.cpp:    if (nodeType != Node::DOCUMENT_NODE &&
> nodeType != Node::DOCUMENT_TYPE_NODE)
> - Source/core/dom/DocumentType.h:DEFINE_NODE_TYPE_CASTS(DocumentType,
nodeType()
> == Node::DOCUMENT_TYPE_NODE);
> 
> And would lead to slightly more readable code.

Right, it is either remove it or start using it, no point in keeping it
otherwise. My new patch changes above spots to call isDocumentTypeNode. First
try-bot is showing up green.

[Inactive, 2014-01-27 16:27:18]

lgtm but please fix the title of your CL before landing (still says "Remove
Node.isDocumentTypeNode").

[commit-bot: I haz the power, 2014-01-27 16:29:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/144063008/40001

[commit-bot: I haz the power, 2014-01-27 16:43:10]

Change committed as 165861