Source/core/dom/Range.cpp - Issue 144063008: Use Node.isDocumentTypeNode more

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Range.cpp

Issue 144063008: Use Node.isDocumentTypeNode more (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Start using isDocumentTypeNode Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Range.cpp

diff --git a/Source/core/dom/Range.cpp b/Source/core/dom/Range.cpp

index 7cee148ee7ba831f58fc67beccde79ad8aad4d80..9c9ac3466ca2d477fbb7498f479c7d8c5a8071f1 100644

--- a/Source/core/dom/Range.cpp

+++ b/Source/core/dom/Range.cpp

@@ -1458,7 +1458,7 @@ void Range::checkDeleteExtract(ExceptionState& exceptionState)

Node* pastLast = pastLastNode();

for (Node* n = firstNode(); n != pastLast; n = NodeTraversal::next(*n)) {

- if (n->nodeType() == Node::DOCUMENT_TYPE_NODE) {

+ if (n->isDocumentTypeNode()) {

exceptionState.throwDOMException(HierarchyRequestError, "The Range contains a doctype node.");

return;

}

« no previous file with comments | « Source/core/dom/Node.cpp ('k') | Source/core/editing/markup.cpp » ('j') | no next file with comments »