components/invalidation/impl/gcm_invalidation_bridge.cc - Issue 1440593004: Make operators on scoped_ptr match the ones defined for std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/invalidation/impl/gcm_invalidation_bridge.cc

Issue 1440593004: Make operators on scoped_ptr match the ones defined for std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: scopedptrequals: followupfix-after-rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/cronet_url_request_adapter.cc ('k') | components/invalidation/impl/gcm_network_channel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/invalidation/impl/gcm_invalidation_bridge.cc

diff --git a/components/invalidation/impl/gcm_invalidation_bridge.cc b/components/invalidation/impl/gcm_invalidation_bridge.cc

index dbc44fe861d7607900126f9a2f604a2490240a29..e05398f9d3d130287b377154719e5b2ffa58deb0 100644

--- a/components/invalidation/impl/gcm_invalidation_bridge.cc

+++ b/components/invalidation/impl/gcm_invalidation_bridge.cc

@@ -214,7 +214,7 @@ void GCMInvalidationBridge::OnGetTokenSuccess(

const std::string& access_token,

const base::Time& expiration_time) {

DCHECK(CalledOnValidThread());

- DCHECK_EQ(access_token_request_, request);

+ DCHECK_EQ(access_token_request_.get(), request);

core_thread_task_runner_->PostTask(

FROM_HERE,

base::Bind(&GCMInvalidationBridge::Core::RequestTokenFinished,

@@ -230,7 +230,7 @@ void GCMInvalidationBridge::OnGetTokenFailure(

const OAuth2TokenService::Request* request,

const GoogleServiceAuthError& error) {