components/cronet/android/cronet_url_request_adapter.cc - Issue 1440593004: Make operators on scoped_ptr match the ones defined for std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/cronet_url_request_adapter.cc

Issue 1440593004: Make operators on scoped_ptr match the ones defined for std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: scopedptrequals: followupfix-after-rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/browser_sync/browser/profile_sync_service.cc ('k') | components/invalidation/impl/gcm_invalidation_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/cronet_url_request_adapter.cc

diff --git a/components/cronet/android/cronet_url_request_adapter.cc b/components/cronet/android/cronet_url_request_adapter.cc

index 46e789375ca562f321f3df9dc483e9576d5a46db..9f9c524be1f626f386d5e1a43a51850698fc72eb 100644

--- a/components/cronet/android/cronet_url_request_adapter.cc

+++ b/components/cronet/android/cronet_url_request_adapter.cc

@@ -380,7 +380,7 @@ void CronetURLRequestAdapter::DestroyOnNetworkThread(bool send_on_canceled) {

bool CronetURLRequestAdapter::MaybeReportError(net::URLRequest* request) const {

DCHECK_NE(net::URLRequestStatus::IO_PENDING, url_request_->status().status());

- DCHECK_EQ(request, url_request_);

+ DCHECK_EQ(request, url_request_.get());

if (url_request_->status().is_success())

return false;

int net_error = url_request_->status().error();

« no previous file with comments | « components/browser_sync/browser/profile_sync_service.cc ('k') | components/invalidation/impl/gcm_invalidation_bridge.cc » ('j') | no next file with comments »