chrome/browser/ui/views/frame/browser_view.cc - Issue 1440593004: Make operators on scoped_ptr match the ones defined for std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 1440593004: Make operators on scoped_ptr match the ones defined for std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: scopedptrequals: followupfix-after-rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/panels/panel_cocoa_unittest.mm ('k') | components/browser_sync/browser/profile_sync_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index 91265cb61edb64d3b84c64df7a3f9997c55f96ad..4b5e6fe39bbb4b6d5e962079a4482e1245a7a8f7 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -2602,7 +2602,7 @@ void BrowserView::ActivateAppModalDialog() const {

Browser* modal_browser =

chrome::FindBrowserWithWebContents(active_dialog->web_contents());

- if (modal_browser && (browser_ != modal_browser)) {

+ if (modal_browser && (browser_.get() != modal_browser)) {

modal_browser->window()->FlashFrame(true);

modal_browser->window()->Activate();

}

« no previous file with comments | « chrome/browser/ui/cocoa/panels/panel_cocoa_unittest.mm ('k') | components/browser_sync/browser/profile_sync_service.cc » ('j') | no next file with comments »