chrome/browser/ui/cocoa/panels/panel_cocoa_unittest.mm - Issue 1440593004: Make operators on scoped_ptr match the ones defined for std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/panels/panel_cocoa_unittest.mm

Issue 1440593004: Make operators on scoped_ptr match the ones defined for std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: scopedptrequals: followupfix-after-rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/panels/panel_cocoa_unittest.mm

diff --git a/chrome/browser/ui/cocoa/panels/panel_cocoa_unittest.mm b/chrome/browser/ui/cocoa/panels/panel_cocoa_unittest.mm

index 1e3f17fe9334727b7e65814ce954b9970f6a38de..d77186a4766966bc18b0d920211aa544920c7354 100644

--- a/chrome/browser/ui/cocoa/panels/panel_cocoa_unittest.mm

+++ b/chrome/browser/ui/cocoa/panels/panel_cocoa_unittest.mm

@@ -59,7 +59,7 @@ class PanelCocoaTest : public CocoaProfileTest {

EXPECT_TRUE(panel->native_panel()); // Native panel is created right away.

PanelCocoa* native_window =

static_cast<PanelCocoa*>(panel->native_panel());

- EXPECT_EQ(panel, native_window->panel_); // Back pointer initialized.

+ EXPECT_EQ(panel, native_window->panel_.get()); // Back pointer initialized.

PanelAnimatedBoundsObserver bounds_observer(panel);

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller_private.mm ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »