[DevTools] Move InspectElement call after OpenDevToolsWindow

[DevTools] Move InspectElement call after OpenDevToolsWindow

This makes it possible to remove Attach call from DevToolsAgent::OnInspectElement and WebDevToolsAgent::Attach call always follows AttachClient call.

BUG=503875, 503824
R=pfeldman@chromium.org, dgozman@chromium.org, tsepez@chromium.org

Committed: https://crrev.com/dbf736422ad7de4242a486591f5ce7a235355b7e
Cr-Commit-Position: refs/heads/master@{#360719}

[kozy, 2015-11-13 18:07:46]

please take a look

[dgozman, 2015-11-13 19:21:56]

dgozman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2015-11-13 19:21:57]

https://codereview.chromium.org/1440383002/diff/1/content/renderer/devtools/d...
File content/renderer/devtools/devtools_agent.cc (right):

https://codereview.chromium.org/1440383002/diff/1/content/renderer/devtools/d...
content/renderer/devtools/devtools_agent.cc:222: if (web_agent) {
Can you check that we are attached already?

https://codereview.chromium.org/1440383002/diff/1/content/renderer/devtools/d...
content/renderer/devtools/devtools_agent.cc:224: is_attached_ = true;
Remove this.

[kozy, 2015-11-15 00:38:46]

Patchset #2 (id:20001) has been deleted

[kozy, 2015-11-15 00:39:05]

All done.

https://codereview.chromium.org/1440383002/diff/1/content/renderer/devtools/d...
File content/renderer/devtools/devtools_agent.cc (right):

https://codereview.chromium.org/1440383002/diff/1/content/renderer/devtools/d...
content/renderer/devtools/devtools_agent.cc:222: if (web_agent) {
On 2015/11/13 19:21:57, dgozman wrote:
> Can you check that we are attached already?

Done.

https://codereview.chromium.org/1440383002/diff/1/content/renderer/devtools/d...
content/renderer/devtools/devtools_agent.cc:224: is_attached_ = true;
On 2015/11/13 19:21:57, dgozman wrote:
> Remove this.

Done.

[dgozman, 2015-11-16 17:15:02]

https://codereview.chromium.org/1440383002/diff/40001/content/renderer/devtoo...
File content/renderer/devtools/devtools_agent.cc (right):

https://codereview.chromium.org/1440383002/diff/40001/content/renderer/devtoo...
content/renderer/devtools/devtools_agent.cc:220: const std::string& host_id, int
x, int y) {
Let's kill the host_id parameter.

https://codereview.chromium.org/1440383002/diff/40001/content/renderer/devtoo...
content/renderer/devtools/devtools_agent.cc:223: DCHECK(is_attached_);
Similar check would be nice if RFDTAH.

[kozy, 2015-11-17 00:25:51]

All done. Please take a look!

https://codereview.chromium.org/1440383002/diff/40001/content/renderer/devtoo...
File content/renderer/devtools/devtools_agent.cc (right):

https://codereview.chromium.org/1440383002/diff/40001/content/renderer/devtoo...
content/renderer/devtools/devtools_agent.cc:220: const std::string& host_id, int
x, int y) {
On 2015/11/16 17:15:02, dgozman wrote:
> Let's kill the host_id parameter.

Done.

https://codereview.chromium.org/1440383002/diff/40001/content/renderer/devtoo...
content/renderer/devtools/devtools_agent.cc:223: DCHECK(is_attached_);
On 2015/11/16 17:15:02, dgozman wrote:
> Similar check would be nice if RFDTAH.

Done.

[dgozman, 2015-11-17 00:28:39]

lgtm

[kozy, 2015-11-17 00:31:38]

Description was changed from

==========
[DevTools] Move InspectElement call after OpenDevToolsWindow

This makes it possible to remove Attach call from
DevToolsAgent::OnInspectElement and WebDevToolsAgent::Attach call always follows
AttachClient call.

BUG=503875, 503824
R=pfeldman@chromium.org
==========

to

==========
[DevTools] Move InspectElement call after OpenDevToolsWindow

This makes it possible to remove Attach call from
DevToolsAgent::OnInspectElement and WebDevToolsAgent::Attach call always follows
AttachClient call.

BUG=503875, 503824
R=pfeldman@chromium.org, dgozman@chromium.org, tsepez@chromium.org
==========

[kozy, 2015-11-17 00:31:39]

kozyatinskiy@chromium.org changed reviewers:
+ tsepez@chromium.org

[kozy, 2015-11-17 00:33:27]

Tom, please take a look.
I've removed unused host_id param from DevToolsAgentMsg_InspectElement message.

[Tom Sepez, 2015-11-17 18:20:19]

Messages LGTM

[kozy, 2015-11-19 02:36:04]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2015-11-19 02:36:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1440383002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1440383002/60001

[commit-bot: I haz the power, 2015-11-19 02:45:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-19 02:45:47]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[kozy, 2015-11-19 05:07:53]

Pavel, ptal.
I need owner lgtm for content/renderer/devtools/devtools_agent.*

[Tom Sepez, 2015-11-19 16:50:34]

Messages LGTM

[kozy, 2015-11-20 01:51:39]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2015-11-20 01:53:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1440383002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1440383002/60001

[commit-bot: I haz the power, 2015-11-20 02:18:14]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-11-20 02:19:11]

Patchset 3 (id:??) landed as
https://crrev.com/dbf736422ad7de4242a486591f5ce7a235355b7e
Cr-Commit-Position: refs/heads/master@{#360719}