Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1716)

Unified Diff: content/renderer/devtools/devtools_agent.cc

Issue 1440383002: [DevTools] Move InspectElement call after OpenDevToolsWindow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/devtools/devtools_agent.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/devtools/devtools_agent.cc
diff --git a/content/renderer/devtools/devtools_agent.cc b/content/renderer/devtools/devtools_agent.cc
index d464b15b941472d2355343dbe50ebf0338cfbf2c..93dfd843cc74e336b8521374a17df21a7a770b11 100644
--- a/content/renderer/devtools/devtools_agent.cc
+++ b/content/renderer/devtools/devtools_agent.cc
@@ -216,13 +216,11 @@ void DevToolsAgent::OnDispatchOnInspectorBackend(const std::string& message) {
web_agent->dispatchOnInspectorBackend(WebString::fromUTF8(message));
}
-void DevToolsAgent::OnInspectElement(
- const std::string& host_id, int x, int y) {
+void DevToolsAgent::OnInspectElement(int x, int y) {
WebDevToolsAgent* web_agent = GetWebAgent();
if (web_agent) {
- web_agent->attach(WebString::fromUTF8(host_id));
+ DCHECK(is_attached_);
web_agent->inspectElementAt(WebPoint(x, y));
- is_attached_ = true;
}
}
« no previous file with comments | « content/renderer/devtools/devtools_agent.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698