Issue 144033002: Add toolchain directory to *.dll name generated by GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 144033002: Add toolchain directory to *.dll name generated by GN. (Closed)

Created:
6 years, 11 months ago by halyavin

Modified:
6 years, 11 months ago

Reviewers:
brettw, bradn

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add toolchain directory to *.dll name generated by GN. This allows to have the same shared library compiled by multiple toolchains. BUG= none TEST= gn_unittest, create a copy of windows toolchain and add references to the same library compiled by normal and copied toolchain. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246302

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	tools/gn/ninja_binary_target_writer.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/halyavin@google.com/144033002/1

6 years, 11 months ago (2014-01-22 06:36:05 UTC) #4

Message was sent while issue was closed.

Change committed as 246302

Expand Messages | Collapse Messages