Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1186)

Unified Diff: tools/gn/ninja_binary_target_writer.cc

Issue 144033002: Add toolchain directory to *.dll name generated by GN. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_binary_target_writer.cc
===================================================================
--- tools/gn/ninja_binary_target_writer.cc (revision 246009)
+++ tools/gn/ninja_binary_target_writer.cc (working copy)
@@ -202,7 +202,10 @@
OutputFile internal_output_file;
if (target_->output_type() == Target::SHARED_LIBRARY) {
if (settings_->IsWin()) {
- internal_output_file = OutputFile(target_->label().name() + ".dll");
+ internal_output_file.value() =
+ target_->settings()->toolchain_output_subdir().value();
+ internal_output_file.value().append(target_->label().name());
+ internal_output_file.value().append(".dll");
} else {
internal_output_file = external_output_file;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698