Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 144023016: Separate Custom Element resolution and upgrade/createdCallback. (Closed)

Created:
6 years, 10 months ago by dominicc (has gone to gerrit)
Modified:
6 years, 10 months ago
Reviewers:
dglazkov
CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org, Inactive
Visibility:
Public.

Description

Separate Custom Element resolution and upgrade/createdCallback. r164309 made Custom Element resolution (searching for a Custom Element definition, and associating it with an element if there was a match) immediately start the upgrade process. This is infelicitous because it changed the timing of the createdCallback in some cases. r164309 added the useful idea of "resolution" as a distinct step that can be deferred. This change refines the integration of HTML Imports and Custom Elements callback timing by separating resolution and upgrade. Now HTML Imports can apply the brakes to resolution without affecting which upgrades happen as a batch. BUG=338135 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166280

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -328 lines) Patch
M LayoutTests/fast/dom/custom/document-register-on-create-callback.html View 2 chunks +12 lines, -7 lines 0 comments Download
M LayoutTests/fast/dom/custom/document-register-on-create-callback-expected.txt View 1 chunk +3 lines, -10 lines 0 comments Download
M Source/core/core.gypi View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/custom/CustomElement.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M Source/core/dom/custom/CustomElementCallbackInvocation.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementCallbackInvocation.cpp View 1 chunk +22 lines, -0 lines 0 comments Download
A Source/core/dom/custom/CustomElementMicrotaskDispatcher.h View 1 chunk +43 lines, -0 lines 0 comments Download
A Source/core/dom/custom/CustomElementMicrotaskDispatcher.cpp View 1 chunk +57 lines, -0 lines 0 comments Download
D Source/core/dom/custom/CustomElementMicrotaskElementStep.h View 1 chunk +0 lines, -60 lines 0 comments Download
D Source/core/dom/custom/CustomElementMicrotaskElementStep.cpp View 1 chunk +0 lines, -57 lines 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskQueue.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
A + Source/core/dom/custom/CustomElementMicrotaskResolutionStep.h View 1 chunk +15 lines, -14 lines 0 comments Download
A + Source/core/dom/custom/CustomElementMicrotaskResolutionStep.cpp View 1 chunk +9 lines, -7 lines 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskStep.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementProcessingStep.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementRegistrationContext.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementRegistrationContext.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
D Source/core/dom/custom/CustomElementResolutionStep.h View 1 chunk +0 lines, -63 lines 0 comments Download
D Source/core/dom/custom/CustomElementResolutionStep.cpp View 1 chunk +0 lines, -59 lines 0 comments Download
M Source/core/dom/custom/CustomElementScheduler.h View 3 chunks +6 lines, -3 lines 0 comments Download
M Source/core/dom/custom/CustomElementScheduler.cpp View 5 chunks +24 lines, -27 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dominicc (has gone to gerrit)
PTAL
6 years, 10 months ago (2014-01-31 07:55:18 UTC) #1
dglazkov
lgtm
6 years, 10 months ago (2014-01-31 18:18:22 UTC) #2
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 10 months ago (2014-02-03 01:15:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/144023016/1
6 years, 10 months ago (2014-02-03 01:16:00 UTC) #4
commit-bot: I haz the power
Change committed as 166280
6 years, 10 months ago (2014-02-03 03:29:38 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 03:29:44 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 03:29:46 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 03:29:47 UTC) #8
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698