Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: Source/core/dom/custom/CustomElementRegistrationContext.cpp

Issue 144023016: Separate Custom Element resolution and upgrade/createdCallback. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/custom/CustomElementRegistrationContext.cpp
diff --git a/Source/core/dom/custom/CustomElementRegistrationContext.cpp b/Source/core/dom/custom/CustomElementRegistrationContext.cpp
index bb1984eb421bfebf5521b098be1c3ad446d1d8b4..bf15f691acc2e7cac21b7abf903d04466c1066f5 100644
--- a/Source/core/dom/custom/CustomElementRegistrationContext.cpp
+++ b/Source/core/dom/custom/CustomElementRegistrationContext.cpp
@@ -74,16 +74,16 @@ PassRefPtr<Element> CustomElementRegistrationContext::createCustomTagElement(Doc
}
element->setCustomElementState(Element::WaitingForUpgrade);
- scheduleResolution(element.get(), nullAtom);
+ resolveOrScheduleResolution(element.get(), nullAtom);
return element.release();
}
void CustomElementRegistrationContext::didGiveTypeExtension(Element* element, const AtomicString& type)
{
- scheduleResolution(element, type);
+ resolveOrScheduleResolution(element, type);
}
-void CustomElementRegistrationContext::scheduleResolution(Element* element, const AtomicString& typeExtension)
+void CustomElementRegistrationContext::resolveOrScheduleResolution(Element* element, const AtomicString& typeExtension)
{
// If an element has a custom tag name it takes precedence over
// the "is" attribute (if any).
@@ -94,7 +94,8 @@ void CustomElementRegistrationContext::scheduleResolution(Element* element, cons
CustomElementDescriptor descriptor(type, element->namespaceURI(), element->localName());
ASSERT(element->customElementState() == Element::WaitingForUpgrade);
- CustomElementScheduler::scheduleResolutionStep(descriptor, element);
+
+ CustomElementScheduler::resolveOrScheduleResolution(this, element, descriptor);
}
void CustomElementRegistrationContext::resolve(Element* element, const CustomElementDescriptor& descriptor)
« no previous file with comments | « Source/core/dom/custom/CustomElementRegistrationContext.h ('k') | Source/core/dom/custom/CustomElementResolutionStep.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698