Issue 14402026: Remove __ prefix from Harmony typed arrays implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14402026: Remove __ prefix from Harmony typed arrays implementation (Closed)

Created:
7 years, 7 months ago by Dmitry Lomov (no reviews)

Modified:
7 years, 7 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove __ prefix from Harmony typed arrays implementation R=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14477

Patch Set 2 : Removed flag implication #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -66 lines)			Patch
M	src/bootstrapper.cc	View		2 chunks	+9 lines, -9 lines	0 comments	Download
M	src/d8.cc	View		1 chunk	+24 lines, -22 lines	0 comments	Download
M	src/flag-definitions.h	View	1	1 chunk	+0 lines, -1 line	1 comment	Download
M	src/macros.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/typedarray.js	View		2 chunks	+9 lines, -9 lines	0 comments	Download
M	test/cctest/test-api.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	test/mjsunit/harmony/typedarrays.js	View		8 chunks	+20 lines, -20 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dmitry Lomov (no reviews)

As discussed offline, removed --harmony => --harmony_typed_arrays implication

7 years, 7 months ago (2013-04-29 10:42:47 UTC) #2

rossberg

LGTM with comment https://codereview.chromium.org/14402026/diff/3001/src/flag-definitions.h File src/flag-definitions.h (left): https://codereview.chromium.org/14402026/diff/3001/src/flag-definitions.h#oldcode180 src/flag-definitions.h:180: DEFINE_implication(harmony, harmony_typed_arrays) Maybe replace this line ...

7 years, 7 months ago (2013-04-29 10:53:55 UTC) #3

Dmitry Lomov (no reviews)

7 years, 7 months ago (2013-04-29 11:18:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r14477 (presubmit successful).

Expand Messages | Collapse Messages

Issue 14402026: Remove __ prefix from Harmony typed arrays implementation (Closed)

Description

Patch Set 1 #

Patch Set 2 : Removed flag implication #

Messages