Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1440193003: [builtins] One runtime fallback is enough for the String constructor. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] One runtime fallback is enough for the String constructor. If inline allocation fails, we can just use the %NewObject fallback, which will do the right thing. We don't need a dedicated fallback to %AllocateInNewSpace. R=verwaest@chromium.org Committed: https://crrev.com/34b7b21d1d7bf2e9c77ae5726f868e69f3b4a4f3 Cr-Commit-Position: refs/heads/master@{#32000}

Patch Set 1 #

Patch Set 2 : Fix typo. #

Patch Set 3 : Fix arm64. #

Patch Set 4 : Another fix. #

Patch Set 5 : Fix scratch registers. #

Patch Set 6 : Use correct temp registers. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -196 lines) Patch
M src/arm/builtins-arm.cc View 1 2 3 4 3 chunks +17 lines, -32 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 2 3 4 3 chunks +18 lines, -31 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 2 chunks +18 lines, -37 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 2 3 4 5 3 chunks +16 lines, -30 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 2 3 4 5 3 chunks +16 lines, -30 lines 0 comments Download
M src/x64/builtins-x64.cc View 2 chunks +18 lines, -36 lines 0 comments Download

Messages

Total messages: 25 (12 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-13 12:46:11 UTC) #1
Benedikt Meurer
Hey Toon, Here's the trivial cleanup we talked about for the StringConstructor. Please take a ...
5 years, 1 month ago (2015-11-13 12:46:43 UTC) #2
Toon Verwaest
lgtm
5 years, 1 month ago (2015-11-13 12:50:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440193003/1
5 years, 1 month ago (2015-11-13 12:53:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel/builds/6702)
5 years, 1 month ago (2015-11-13 12:59:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440193003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440193003/20001
5 years, 1 month ago (2015-11-13 13:03:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440193003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440193003/60001
5 years, 1 month ago (2015-11-13 13:23:23 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/10104)
5 years, 1 month ago (2015-11-13 13:45:23 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440193003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440193003/80001
5 years, 1 month ago (2015-11-13 13:53:59 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel/builds/6709)
5 years, 1 month ago (2015-11-13 13:56:28 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440193003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440193003/100001
5 years, 1 month ago (2015-11-15 18:59:59 UTC) #23
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 1 month ago (2015-11-15 19:19:05 UTC) #24
commit-bot: I haz the power
5 years, 1 month ago (2015-11-15 19:19:39 UTC) #25
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/34b7b21d1d7bf2e9c77ae5726f868e69f3b4a4f3
Cr-Commit-Position: refs/heads/master@{#32000}

Powered by Google App Engine
This is Rietveld 408576698