src/ia32/macro-assembler-ia32.h - Issue 1440193003: [builtins] One runtime fallback is enough for the String constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/macro-assembler-ia32.h

Issue 1440193003: [builtins] One runtime fallback is enough for the String constructor. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Use correct temp registers. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/macro-assembler-ia32.h

diff --git a/src/ia32/macro-assembler-ia32.h b/src/ia32/macro-assembler-ia32.h

index bff3c041a4f130dcf5630ba316b8dc0fbf6a0ff3..51027ea78c063652970a2936cfc90301e2c23cb3 100644

--- a/src/ia32/macro-assembler-ia32.h

+++ b/src/ia32/macro-assembler-ia32.h

@@ -841,6 +841,7 @@ class MacroAssembler: public Assembler {

void Push(const Operand& src) { push(src); }

void Push(Immediate value) { push(value); }

void Pop(Register dst) { pop(dst); }

+ void Pop(const Operand& dst) { pop(dst); }

void PushReturnAddressFrom(Register src) { push(src); }

void PopReturnAddressTo(Register dst) { pop(dst); }

« no previous file with comments | « src/ia32/builtins-ia32.cc ('k') | src/mips/builtins-mips.cc » ('j') | no next file with comments »