Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1440173003: Revert of Enable AutoResize for Constrained Web Dialogs for Mac. (Closed)

Created:
5 years, 1 month ago by apacible
Modified:
5 years, 1 month ago
Reviewers:
erikchen, Nico
CC:
chromium-reviews, extensions-reviews_chromium.org, rouslan+autofill_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, estade+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable AutoResize for Constrained Web Dialogs for Mac. (patchset #4 id:650001 of https://codereview.chromium.org/1430023002/ ) Reason for revert: This is breaking Mac10.9 browser_tests (flaky): https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/11410 https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/11410/steps/browser_tests%20on%20Mac-10.9/logs/ConstrainedWebDialogBrowserTest.ContentResizeInAutoResizingDialog Original issue's description: > Enable AutoResize for Constrained Web Dialogs for Mac. > > Currently only constrained web dialogs for views (Linux/Windows) are able to > autoresize. This change implements the option to pass in minimum and maximum > sizes and enabling autoresizing functionality for OSX. > > This change adds two static functions for options on whether to create a > ConstrainedWindowsMac that autoresizes or is of fixed size. > > BUG=217034 > > Committed: https://crrev.com/0dbc8ff6d68291773b8b233a19e399d00f9262b0 > Cr-Commit-Position: refs/heads/master@{#359497} TBR=thakis@chromium.org,erikchen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=217034 Committed: https://crrev.com/5acf85a4aebf309d5cb11c6774ef3a067d12a21a Cr-Commit-Position: refs/heads/master@{#359593}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -267 lines) Patch
M chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/certificate_viewer_mac.mm View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm View 8 chunks +17 lines, -137 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h View 4 chunks +0 lines, -25 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm View 2 chunks +7 lines, -34 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm View 4 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller_unittest.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_web_dialog_sheet.mm View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/login_prompt_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/one_click_signin_dialog_controller.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_dialog_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/user_manager_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_views_mac.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_ui.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc View 6 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
apacible
Created Revert of Enable AutoResize for Constrained Web Dialogs for Mac.
5 years, 1 month ago (2015-11-13 19:10:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1440173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1440173003/1
5 years, 1 month ago (2015-11-13 19:11:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 19:14:00 UTC) #4
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 19:14:43 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5acf85a4aebf309d5cb11c6774ef3a067d12a21a
Cr-Commit-Position: refs/heads/master@{#359593}

Powered by Google App Engine
This is Rietveld 408576698