chrome/browser/ui/cocoa/one_click_signin_dialog_controller.mm - Issue 1440173003: Revert of Enable AutoResize for Constrained Web Dialogs for Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/one_click_signin_dialog_controller.mm

Issue 1440173003: Revert of Enable AutoResize for Constrained Web Dialogs for Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/login_prompt_cocoa.mm ('k') | chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_dialog_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/one_click_signin_dialog_controller.mm

diff --git a/chrome/browser/ui/cocoa/one_click_signin_dialog_controller.mm b/chrome/browser/ui/cocoa/one_click_signin_dialog_controller.mm

index 480dfcfdd74d82e6b4f3a010642bac18a608b46f..f0156f2b4e7a1223aa8d4470568a967557828ed5 100644

--- a/chrome/browser/ui/cocoa/one_click_signin_dialog_controller.mm

+++ b/chrome/browser/ui/cocoa/one_click_signin_dialog_controller.mm

@@ -30,15 +30,15 @@

base::scoped_nsobject<CustomConstrainedWindowSheet> sheet(

[[CustomConstrainedWindowSheet alloc] initWithCustomWindow:window]);

- constrained_window_.reset(

- CreateAndShowWebModalDialogMac(this, web_contents, sheet));

+ constrained_window_.reset(new ConstrainedWindowMac(

+ this, web_contents, sheet));

}

OneClickSigninDialogController::~OneClickSigninDialogController() {

}

void OneClickSigninDialogController::OnConstrainedWindowClosed(

- ConstrainedWindowMac* window) {

+ ConstrainedWindowMac* window) {

[view_controller_ viewWillClose];

base::MessageLoop::current()->DeleteSoon(FROM_HERE, this);

}